[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools: Move MASK_INSR to common-macros.h
- To: Jan Beulich <jbeulich@xxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 9 Jun 2023 11:10:20 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ff4nZVtzN8zb9/AOwMi8Rs+t6C439FiqvtWuwSUXTcM=; b=CvOjpmVc75ldNrKT/0kHCrlMimFE0eQKheVSR1UvMyAERfxQwXn9PnzUAroyjDYUfVNrazIYzamsIEIMHOe2XQGS3ZFqG5Kn9obugMAORrzDc2PktmHfXtILs3Qw8Iwqj/FT669v1hmMaPGy1vqxzwIanQTP1tfPNqEyIVmWieV2UIHPUzr9IelbYgmqGNMiRGJyKEpTTIwGgH1VThts7FT2GJ2kEJ0eHJitXp8i+BIB2uL2lMPaY28WbBfxsUyzcS2tCEG2OVHZhkA5MPJeEjXv3QwxKzJ9yVRAahKrXn9JAShZ6xQu2sKSjJ9/XA2WyKoaRswMag02tjEFbYIJdg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyGzLOSdGRaX50umAyHqKVfGLcqqwOTtkB4lfq1ab+sLhHPOT84hfCz5B4XWM3K5sJBveStR5SjKmYb7u7Y0CrhRI5D2G42gLU0bgsAD/jMYWOS52LMO9XeDnLC+2c7t/d2JP908vPt8q+T+G2cjiPNAXkUDGhV3PpEif+EVgSdrBUlbkVrdD1cMm0pv56T9HVE3LqnCrC8m9mHIsaGTQ91KNdN5R7Zj27CgxiP8lcH0ELXcSoz7P3iYpPpsJLHFakbHTXuVFVw1QFVtjIt8K00rY55AHvTLboyHEodPxJyqaXv5awZomLXB+VUVK4bXk/ZuumYTiuLCwR9kH3fE8g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 09 Jun 2023 10:10:46 +0000
- Ironport-data: A9a23:iS9H1aohuLBYZxTAjtqHI/vPMvFeBmLZZBIvgKrLsJaIsI4StFCzt garIBmEbP+KMTajeNsibtux8hgEvZPQx9NiGgRo+SwzECsT85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GtwUmAWP6gR5weAzylNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACEAbSCmg/uU+/W2Ztlzh+0qPcvLE5xK7xmMzRmBZRonabbqZvyToPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeeraYWNEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhr6I12A3Mmjd75Bs+CBiF4ue/1HOFXfV8c Es04DAFpPIO6xn+JjX6d1jiyJKehTYeUddNF+wx6CmW17HZpQ2eAwAsSiNKYZoovck9SDguy 3eAhdavDjtq2JWXRmia7ay8ti6pNG4eKmpqTT8JS04J7sfupKk3jwnTVZBzHaitlNr3FDrsh TeQo0ADa647iMcK0+C3+A7Bijf1/5zRFFdqvkPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytalUwXXYH80EdygmQ
- Ironport-hdrordr: A9a23:4lmoTKpElZya+rkgcGfpDZEaV5v+LNV00zEX/kB9WHVpm5Oj+f xGzc516farslossSkb6Ky90KnpewK5yXcH2/hvAV7CZniqhILMFusC0WKM+UyZJ8STzJ8+6U 4kSdkCNDSSNyk3sS+Z2njCLz9I+rDum83J9ITjJjVWPHtXgspbnmBE43OgYzRLrX59dPwE/f Snl696jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA H+4kLEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut jRpBULOdh19hrqDy6IiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ/O1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh7rD3vXklUqvoLhiKrLzPI9 MeS/00I8wmN29yWkqp+1WHBubcB0jbUC32GnTq8fblrQS+1EoJvnfwgvZv30soxdYFUJ9D6P 3DMqN00J9zbuJ+V9MnOM4xBfKtDGrDWBTNN3/XB2/GOuUoB1LhwqSHuoncwomRCcA1JV8J6c n8eUIdumgod030D8qSmJVN7xDWWW24GS/g08dE+vFCy/XBrRXQQFi+oX0V4r2dSs8kc4Tmcu f2PIgTD+7oLGPoF4oM1wriW4NKIX1bVMEOoN40V1+Hv8qOc+TRx6bmWeeWIKCoHScvW2v5DH dGVD/vJN9Y5kTuXnPjmhDeV37kZ0S695NtF6rR+fQV1eE2R8ZxmxlQjU786tCAKDVEvKBzdE xiIKn/mqf+vmWy9Xag1RQfBvOcNDcg3FzNaQI5meZRCTKFTV8qgaTtRVxv
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/06/2023 10:33 am, Andrew Cooper wrote:
> On 09/06/2023 10:31 am, Jan Beulich wrote:
>> On 08.06.2023 19:40, Andrew Cooper wrote:
>>> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together.
>> Right, that's one thing which should have been done right away.
>> The other is that both macros should have been purged from
>> tools/tests/x86_emulator/x86-emulate.h (which includes
>> xen-tools/common-macros.h). Luca?
> Hmm - I explicitly checked that, and concluded they didn't... Happy to
> purge them if I'm wrong.
I think I was looking in an old branch. Fixed for v2.
~Andrew
|
