[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] CI: Add Ocaml to the alpine containers
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Fri, 9 Jun 2023 18:21:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RMXJzclzwmtePPxoLNGkq/Rld4HKgylg+yA34roB5Wk=; b=h8iTQVBpVo88LDLrdekPQ4Bf6zyqErZ5QlA6qBQ8XdO9mK3E5wc3vSIT2Q6KcMfq+Fwvgx52nBxcTXVu69Azw7HiVJy/hZVAfnDF6ryROBdSdAWrQAyAMEfymV5N4JML0YT7ryQayI4tno3SOcVSJKmP0mIxajn4QNd0GBq8wh8aQ1Qwp6DJispE89UBQDA3BmosTL4ExiYWquFDrc8FdAJt1usExOH21BryYj/ZXnBnWTjG2FXR76bDtmrqWbgl+vVaa/uyDFrAcVl/VpPzQ4A9VqgniP/rJxb9LkwI3rrFB9C610+6dIwd5mN9VdJOchDNvOa5u+03IChcFuM9LQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BI0qkqp3UPglu5VakniH1Cp5PtKPjsFM0YxpWCi3dNlmHro2dvZs99670urfTV/Go/qVEzvZvm2v18eD4xr3PPqpV3Dj5xVlK8+yH7RjAikg7KP2u/qQzzGiKX1j9J26Re03VQgqS44L5B2dCtsn/JblVMHsQ3Qutvcs5Ug1wISR6ZN0/i12Mwb4o1PR9x82fbdysQZm8cPR1Vp7uUMH83UszvDOFSkl2A/EQ9MLtdVK8xm9Jy6E1xBxwp/5Vzssimke1iEnGjcnkVF/AFcCBNaRETwym4ilp9YN1sTSZThfsR+bw+sWPqy9e5c7sDKsd6lund4l2O2NviMkl2xXEg==
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 09 Jun 2023 16:22:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/06/2023 18:02, Andrew Cooper wrote:
>
>
> This gets more coverage of optional parts of the build, and makes it easier to
> trial Ocaml related changes in the smoke tests.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Michal Orzel <michal.orzel@xxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> Hacked up manually to fix the Ocaml bindings for arm64:
>
> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/895162017
>
> but this aspect should be done irrespective.
> ---
> automation/build/alpine/3.12-arm64v8.dockerfile | 2 ++
> automation/build/alpine/3.12.dockerfile | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/automation/build/alpine/3.12-arm64v8.dockerfile
> b/automation/build/alpine/3.12-arm64v8.dockerfile
> index 3f1e6a3fc6df..1be3bf780509 100644
> --- a/automation/build/alpine/3.12-arm64v8.dockerfile
> +++ b/automation/build/alpine/3.12-arm64v8.dockerfile
> @@ -28,6 +28,8 @@ RUN apk --no-cache add \
> make \
> musl-dev \
> ncurses-dev \
> + ocaml \
> + ocaml-findlib \
I can see that in your CI pipeline, this package is missing. Is it then
necessary to be added?
Asking just out of curiosity because other containers have it installed too.
Apart from that, I can confirm that containers can be built without issues, so:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
