[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] CI: Add Ocaml to the alpine containers
- To: Michal Orzel <michal.orzel@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 9 Jun 2023 17:31:24 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2GXKUFISuOzwzr28Y+RztO8dzbl/qmQbueQtx8ybKJk=; b=Q0hflLDRd26AfEV4qqoowdK7msCkBVSOKqYa9zM+RyrMVBS95g3Zhn7/dzRpUTNQaFRcZhoaJyfosADBAaYqkjAMNXETSGofSPGU0zKSs6LZvgVyezI7Ilpgeq0WX/9bi5uc2SpSlYW4T3SMZEQdskoAgNJq61OcfOrhBT0VkYbT6oK0Zn7rtpwp8IDQ8KvF4lpYrBqMV7uMMoSMqzlgLSZ1E8uGBcC2YKYyuE33o9lq865hwqIJksAfexzM4gZhKkD7oJu3FBpv0+JrREygNEfMP0Fem+8crVn8nDAoIPfKhyWFdBQJPsPfI/+iDGve5Gn67lY0OsgJVdo5bErDXA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ek6j03lnfIxA1rUV5mCJk5Px8APNshe89MNKV8/BUhuxochG6P++9qemxb/hglgRgm+MljnEq9ZWk+MYhdK0SyJLUr+0IqdUwgfgCMYFS+do2CUJUOD9D6/hptgBPJ+KOgL4KcQZSvRDKyBOUOPzdsBnTIXvBH9nCZ9cKm5iShk8fqjZawXkCsAoL2hdgNvG/GsJNi5hVQLmDDCwtE2J6R5zakH4f9hIGrnJUWDEDjqGkdCUwexsdxT0VWAvUG5J3D7nnRBMaOXCm2agTnblbRKpTJDdbSv+L6Ibpx1uw7pXXEYRa8raXdVGSCPL5w39E2umQBmTQ50slj4FfF/WWw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 09 Jun 2023 16:31:54 +0000
- Ironport-data: A9a23:ZojgJaK290LD5xuZFE+R45QlxSXFcZb7ZxGr2PjKsXjdYENS1T0Pn GYYUD3SPf3bYGumfN0iOd6y905XvsDTyN9qHQFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrbwP9TlK6q4mhA4ARvPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5YAVBIr /I/JQkDYzGDgsSK8p+8Q8xj05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMlWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHqhBt9PSO3knhJsqEW2gVYLNAdJbwW6i9Sot0uYBIpQO 0NBr0LCqoB3riRHVOLVWhyzoHeA+BkGSddUO+Q/5EeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kOYgnnS99iFOu5i4PzEDSpm jSS9nFh3vMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIsxqByMMhm4UmxqRGw
- Ironport-hdrordr: A9a23:pm4Ig6g8Ytm6qXpEGwdAmQaRhnBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/06/2023 5:21 pm, Michal Orzel wrote:
> On 09/06/2023 18:02, Andrew Cooper wrote:
>> This gets more coverage of optional parts of the build, and makes it easier
>> to
>> trial Ocaml related changes in the smoke tests.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> CC: Michal Orzel <michal.orzel@xxxxxxx>
>> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>
>> Hacked up manually to fix the Ocaml bindings for arm64:
>>
>> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/895162017
>>
>> but this aspect should be done irrespective.
>> ---
>> automation/build/alpine/3.12-arm64v8.dockerfile | 2 ++
>> automation/build/alpine/3.12.dockerfile | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/automation/build/alpine/3.12-arm64v8.dockerfile
>> b/automation/build/alpine/3.12-arm64v8.dockerfile
>> index 3f1e6a3fc6df..1be3bf780509 100644
>> --- a/automation/build/alpine/3.12-arm64v8.dockerfile
>> +++ b/automation/build/alpine/3.12-arm64v8.dockerfile
>> @@ -28,6 +28,8 @@ RUN apk --no-cache add \
>> make \
>> musl-dev \
>> ncurses-dev \
>> + ocaml \
>> + ocaml-findlib \
> I can see that in your CI pipeline, this package is missing. Is it then
> necessary to be added?
> Asking just out of curiosity because other containers have it installed too.
>
> Apart from that, I can confirm that containers can be built without issues,
> so:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Thanks. It is necessary, yes.
I missed it the first time around, and deployed updated container to
rerun the failed job, rather than pushing a full new branch.
I'm unsure why the opensuse containers have ocaml-ocamlbuild and
ocaml-ocamldoc too, but that can be a mystery for another day.
~Andrew
|
