[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] tools: fix make rpmball
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 12 Jun 2023 13:44:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HunZ1Ybqmh3jQqmttIU82H5hOmm602MiozqinnZGkmc=; b=QAop4zRk8gKt/9MnjIBV9JmY/n6yheQndpKaC7ssXIcGZ9B0Tpn+be992lYV5f9rc14rAq1hdJCmHaRkXVRgoaz2t9coJvjf8jiYw2pzG1CUrtsEZC2xFYYYa+HOIELrW+gZaiTRYQ1c6eCPy0h3ULn0e6v+PbnXtgPa6/aWCR1W/CuRge7Ez8cQ+qBTyIpO9M99HDG6GabKQn9n80eSxqQ4FfFOQargJRQHaFNJv2RYpsixPFQ/PG/F50ieOmM8f2g6GrVcJNHaochCbGEpuWKe2or37uCao7XJneebeDLJIJEr7gm4zhVzOXZq9f3Wq6T6ys03CexxH1qxwFF+mA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZxEAiqJUxrARTyhLehUh6YoOqEdXjQO/TQ5gyC0tg9f4FAb5MCypFsP+Skf/NFcz/Fni++Zf9UIjn7pjRt0ggWjMQ4V/Me3KxCzqhcx0a3/UenjA7iRXLIjm9TY1qdZFjqrTSmxrjs0hS8/ehalN229GfULvkvHLI+uXAqaGwnCr54dc8S5oRRLSqeuXu21/ND7GAb2bv2bnO/s4U0ndVtqGn2QF5OnYyD3FyXGokGX0DF8KTWL4FUR8pfeXs2qc8q0WasG0ramDVe2hh0yocYyA0JbmYOs9dlKXQQG3kp+ZZSmJJbJ9Ev85RwoMqJdDzf2HZkNNq0kncEoZ+IYJNA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 12 Jun 2023 11:44:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.06.2023 13:35, Olaf Hering wrote:
> Mon, 12 Jun 2023 11:40:55 +0100 Anthony PERARD <anthony.perard@xxxxxxxxxx>:
>
>> On Tue, May 30, 2023 at 01:18:07PM +0200, Olaf Hering wrote:
>>> +pushd %buildroot
>>> +popd
>> Are these 2 lines left over from testing? They don't appear to do
>> anything useful.
>
> I think the intention was to test if mkdir succeeded. But then it
> should have been right after mkdir...
>
> I will send v2 without these two lines.
I'd be fine dropping them while committing.
Jan
|