[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/5] xen-mfndump: drop dead assignment to "page" from lookup_pte_func()
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 12 Jun 2023 13:45:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1YzWXeZ3z6bC+mXj26Xjsu53Z/uSpydklQeVDdytmY=; b=kpp+DfTPJPbW4bTuPk3rGFXT4nT+rPAivFHH61hAZk1GPWdCVe4yz0JC8WVRxYeqZpwLq/KGV5hTKzGLLp9LvPLLYPlsHwSK7DeSEc2Rf2Aa10iT7KA0waQ4qHy0zI440FYoJRgy1xTmKjS4M7M8oX8aRSCJkSkt/V2Mogf0os6lHN0xsCIR8C3vLDSnqC1Pc5YhVTXAvyaVLW0DoB8fsHVLJ+mnR4aaonLr50W9d14DiDeD2vnkPgc5R13MwZ6PzfZZ7SrCfy2cbDn59kO/0Zm5IYckCjZKYjGaFHUrmj/0Ny8YY/zhz6auWv7Ol18UQ/JPmskxYn32cZxWXcx1HQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YibojOIAdW5tPGK2VycNy0yipEcUu2k0A+xhpKTNoBQVWarroikS4pJgYoWE2YdEC/r23QEReyAv7AjGOmY7D9vkNR96Ehxpne1hEh1U+7XMj1YUXFDMdPgvJtimLuXngLHgczOXXuKPPg+GijS/qUkDIkh+qBAay3y456kPP9J0daF8dUxWZDEDk3yMQjy8Q4sbYY9jJikd/GuEeHH+Rg6y9Qh+f5maaZqHp5Y2LY9US6nex5FYBdQtRJkeyw67IHpTl7i3xAsnXkJqVpRSNesxbxHeI1eppYJMz3U4AVAqGfJrcHewubHgVsb8/tu+hPZDeNZ562UwcC/9OnCDfg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 12 Jun 2023 11:45:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The variable isn't used past the loop, and its value also isn't
meaningful across iterations. Reduce its scope to make this more
obvious.
Coverity ID: 1532310
Fixes: ae763e422430 ("tools/misc: introduce xen-mfndump")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/tools/misc/xen-mfndump.c
+++ b/tools/misc/xen-mfndump.c
@@ -265,7 +265,6 @@ int lookup_pte_func(int argc, char *argv
{
struct xc_domain_meminfo minfo;
xc_domaininfo_t info;
- void *page = NULL;
unsigned long i, j;
int domid, pte_num;
xen_pfn_t mfn;
@@ -301,6 +300,8 @@ int lookup_pte_func(int argc, char *argv
for ( i = 0; i < minfo.p2m_size; i++ )
{
+ void *page;
+
if ( !(minfo.pfn_type[i] & XEN_DOMCTL_PFINFO_LTABTYPE_MASK) )
continue;
@@ -323,7 +324,6 @@ int lookup_pte_func(int argc, char *argv
}
munmap(page, XC_PAGE_SIZE);
- page = NULL;
}
xc_unmap_domain_meminfo(xch, &minfo);
|
