[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] libxl: drop dead assignments to "ret" from libxl__domain_config_setdefault()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Mon, 12 Jun 2023 15:44:30 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686599074; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=dJqE0sJlYljjw4V/g9QK786r+d/iX2nD8sgbwxfPqmk=; b=grfBLYKmNBAC568xrTsgY559fRZOzTgjzoc6XNO02Mf1Gt9o9a5MbT0Di00dfMaxBXhkl42I930xkFNed08VSQC1KuCnMfDSpp11cgvPAA8/VjVyUhMgaPBBE3HDgmfnFN60vrIUJhMN6dNP2D8nVFeFuG+hfQzvqgGfGQXBn7g=
- Arc-seal: i=1; a=rsa-sha256; t=1686599074; cv=none; d=zohomail.com; s=zohoarc; b=e3TsX/VqN5IsEGH8feCKgXw2o+bqOReL2QrNFggGGLD081vx+rIFvS64QVjS4oq5f6OrNQCwpeMSQ1+S2nr67J7I4aqK136HB3biKUv0GNuMn+gVgoHb2QHVcD0YLlGtMhd2sNC2YXVYJ17DFN/B9lwKjq41VfbcCO0pDJcYK6E=
- Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Mon, 12 Jun 2023 19:44:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 6/12/23 07:46, Jan Beulich wrote:
The variable needs to be properly set only on the error paths.
Coverity ID: 1532311
Fixes: ab4440112bec ("xl / libxl: push parsing of SSID and CPU pool ID down to
libxl")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxx>
---
If XSM is disabled, is it really useful to issue the 2nd and 3rd calls
if the 1st yielded ENOSYS?
Would you be okay with the calls staying if instead on the first
invocation of any libxl_flask_* method, flask status was checked and
stored in a variable that would then be checked by any subsequent calls
and immediately returned if flask was not enabled?
v/r,
dps
|
