[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Append a newline character to panic() where missing
- To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 14 Jun 2023 09:04:45 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y0ms2YejFOSpaRTBFCXaCHlmXXiuzo5e0M6nCbzl2nQ=; b=g55UM0AUMqCeJsAHwZKz0JDmMOKMcVjXngQszk5VaPkxhe6UnrtCC+rcSb/ReezdSPmH2TRP8oicDCMAQIf1Iedscg15pJNgRRdj+5HDdwd1rbhsI+cSku3mYWo8UHhdL35BxO136XcwjXOMurhvFJhwMYIlvM93WMXl9QRFLFbu4LhLASq0hyFf3ucPr5EmCmQqCxrvNFjxQcsG47lligSobjwEAYi0h2aMh85xOEPR8JoXh3tSK3gbNsExNFZtsXi6aVA4vMCIW7dV9M5Un4kSCZ9SLjazWBXOKR1eACZJPghWAAy0PSGg/hkbh4rEIQwYkGACgm6UoO5vCQzmSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oyr3lUSD44aQtO1u2PAdgOgub6rlnLnlDQbwkTLqbyXHl7/Lqw+voxhaWxckKO20Z+DCdyFBKPhqG+NrLKgn4leoE4+tTtFbbGfTjtJTNyl6EdRCYv/l+ULmv6od4N2sE2dGrItkkqIHknea6n20P9RE7TM6QD1msXY9dk9Vs03ZC+7MWBO+V7ZywTNgjtyzGNwRf+1zU0CADuPg+VIOBlAZbfDqpZgdOHe2SQkBqBMJOSRndtfgSLjKATxDdipv5nkVrJ2ApyR9IJBHYteXAlmwq+QLuvG2VH7ArBdF9g1zGrKAgR4s6OuEnTbbT+zEny7xQQzQvh5rmbkFrX0vXA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 14 Jun 2023 08:05:09 +0000
- Ironport-data: A9a23:gjDzLqu5FuStmaEkr1AntS5cn+fnVMhfMUV32f8akzHdYApBsoF/q tZmKTvXaP+JZWP2etxyOdu39R4GuZDUxt82SARu/itgHioR+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Fv0gnRkPaoQ5AGHyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwDD8ubDXAteGM2ZGnQM9Du8saJcjWM9ZK0p1g5Wmx4fcOZ7nmGv+PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ovjv6xYLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTiqaIz2wHIroAVIAAzbHiSnPa8sETgQdhkd kw6+ncvqIFnoSRHSfG4BXVUukWsux8XW9NUVeog+gyJ4qPR70CSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5LErOxj9DzMSH9x XaNtidWr78el9IR3qO3u1XOmSuxp4PhRxQwoA7QWwqN0AR9Y4K0Yp2y3nLS5/1AMYWxQ0GIu T4PnM32xOIEAIyJlSeNaP4QB7zv7PGAWBXDhXZ/Ep9n8C6ik0NPZqhV6TB6YUJ2aMANfGazZ FeJ4V8BophOIHGtcKl7JZqrDNgnxrThEtKjUe3Iat1JYd56cwrvEDxSWHN8FlvFyCAE+ZzT8 7/CGSpwJR720Zha8Qc=
- Ironport-hdrordr: A9a23:+3xfd6CYRN9iarjlHej9sceALOsnbusQ8zAXP0AYc20uTiX4rb HdoB1/73DJYVkqKQ0dcLy7SdG9qDbnhO9ICMoqTP6ftWrdyRiVxeNZnPTfKmbbalvDH4dmvM 8KGcUOb6yXfCFHZITBkXmF+r0bsaS6Gc6T9Jzj5kYoZyFGL4pJ1W5Ce2SmO3wzbilqQbEHL/ Onl6l6jgvlU1Q7KuuSLEQiZIH41rj2vaOjSz4qQzoK1SHmt1OVwY+/OTi0mjFbcxRh594ZkF TtokjSxojmirWB9jrxvlW8071m3P/d6LJ4dbmxY7AuW0vRozftQIxgXr2EsnQRoPuzgWxa2O Ukuy1QSPib9UmhCl2dkF/Q5ynMuQxDmhvf9WM=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/06/2023 8:30 am, Michal Orzel wrote:
> Missing newline is inconsistent with the rest of the callers, since
> panic() expects it.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
although...
> ---
> xen/arch/arm/bootfdt.c | 2 +-
> xen/arch/arm/domain_build.c | 6 +++---
> xen/arch/x86/cpu/microcode/core.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index b6f92a174f5f..2673ad17a1e1 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -225,7 +225,7 @@ static int __init process_reserved_memory_node(const void
> *fdt, int node,
> size_cells, data);
>
> if ( rc == -ENOSPC )
> - panic("Max number of supported reserved-memory regions reached.");
> + panic("Max number of supported reserved-memory regions reached.\n");
Trailing punctuation like . or ! is useless. Most messages don't have
them, and it just takes up space in .rodata, the console ring, and time
on the UART.
I'd recommend dropping the ones you modify, and/or cleaning it up more
widely.
~Andrew
|
