[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Append a newline character to panic() where missing
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 14 Jun 2023 10:09:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rXdTZvQddnn9tDkcSVp70wA46r1lK68Zs0r330WqhS8=; b=PKL/EMGB3txthkRs3FARp9Jd/LoPZ/x/ejIY3V7SAx//7ZBTuk5ssoQycbdAWDFdz5oxi87QiMjzirb0gfX3++mJWLq87G6TSdZu4LBClabSKlRMmZTnZ87u3Wl3KKHeLnx9mqCpmQpcRDC9RKdCb1FZ3t10Ir2sfxcbYt5bM1eAevzm6aOWkrQXTQI/AAnoqfI8g01Q8pKarWDe6XLk6zcdy64X72ko3SunMBis+QTN3HTacslh7lxpSUBp7lJWOSWqV8aYEbYptP4yUJd5wAnAUMK0+pkFQrZTDsKuqzEQ+xP6DcQFHkF8F4rfvDlNwZa4Qdg+vSyYZ/qmYzYhTw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a9CsL5yXVYh3tPYkwD+Agb1Ak3SLkEcOueSpLYxtljZNHxVzuqjnI4t0TrjLJYfCxeL56mbdLI4GmbRpXkkYtTUy1uM072jCEpUnmi1qWzRMGWJJwUatnnJOPqr7rg1VvoNLy2//cGXMXdPxZScs4JyhVLLplzqpxnhCWngB6AD7Ge/ZaloflJ1L01FT7AchPpRjiNO5IUu0LUkC9nY4YR++jbjnZeeIOoYChDlB9XxT/h+fyUrhkg9R7wKKEMjkAx4K3iZnIV19Jhtc84b5oRKKNh5iTtXYb4M2fsxB1OHK69Eyv2yzlaaYR/SLP02/6LXet1Ee/G8WACnVgVAzfA==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 14 Jun 2023 08:10:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/06/2023 10:04, Andrew Cooper wrote:
>
>
> On 14/06/2023 8:30 am, Michal Orzel wrote:
>> Missing newline is inconsistent with the rest of the callers, since
>> panic() expects it.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> although...
>
>> ---
>> xen/arch/arm/bootfdt.c | 2 +-
>> xen/arch/arm/domain_build.c | 6 +++---
>> xen/arch/x86/cpu/microcode/core.c | 2 +-
>> 3 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
>> index b6f92a174f5f..2673ad17a1e1 100644
>> --- a/xen/arch/arm/bootfdt.c
>> +++ b/xen/arch/arm/bootfdt.c
>> @@ -225,7 +225,7 @@ static int __init process_reserved_memory_node(const
>> void *fdt, int node,
>> size_cells, data);
>>
>> if ( rc == -ENOSPC )
>> - panic("Max number of supported reserved-memory regions reached.");
>> + panic("Max number of supported reserved-memory regions reached.\n");
>
> Trailing punctuation like . or ! is useless. Most messages don't have
> them, and it just takes up space in .rodata, the console ring, and time
> on the UART.
>
> I'd recommend dropping the ones you modify, and/or cleaning it up more
> widely.
I will keep in mind to do that in global scope in the next patch.
We also have quite a lot of printk() with trailing punctuation.
~Michal
|
