[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/evtchn: Purge ERROR_EXIT{,_DOM}()
- To: Jan Beulich <jbeulich@xxxxxxxx>, Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 14 Jun 2023 10:21:48 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/p6wk7Zbj763leAtBPF/DRevuEDBQhgJIb3HopmlTlU=; b=HV6FkOPSddc4tq1w9HwqzTHayZrq9ovyCenXJ3yL8HV1DTtdhl+u1BZaZMaav9WqYhVD7979ntr++7aMN4mMtX891DcIRsuVLUxXgrC28uC+HaO99n+k0Gam4uPGRYDdbI1WByrvOsxGjMPXx68VKugSBHtWCdZnnu/6ceFL6V+CSJh5Cwg2MPTNo6oMMQOxvT/cGvLvLWcValbIUan62xfd5R+WCR7fFv6yy7eE+pvQGfzeAVPgz2DYGTY0+p7b0JVZBSMLDcNU2JCdYotqVYcRSdrDKT8SXvOTa5VOMJqJAv3tnJ6vq6/pEMcB29lYRfNKiyWhGYJHQyIhz3TtrA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTpVjVArUsdNE9pqrYYB2Rg95Yl4LgH9lM9tg+hAKMdXkBDqvtjSCIviFFHO2HoAIs5b6kDlI/9chR3v3m/bP7sG4pavxO+4M4KrwgikkDZg+/uTi8d+pOvtE2N54TbbhVZCEbUBoFx6neHgN/KLrmAXLMrppkMZqq1k845m1/4eAfZbX4RlWkf/8zggC/BYscyR55DQNEzDF8z+uim9iwspxOb+rKRJcmhDTNtA/iEcKP79iXpnIgfy5s6ZesTyC/gWJxfCVMCfYzLJVjSWvA8ZNo4la+Zr0kATx8QN8aNw8U/aYlF67hQhdtl/hr4EYJZM369vq4G9Fi+Omqlqzg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <amc96@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 14 Jun 2023 09:22:37 +0000
- Ironport-data: A9a23:3F1Ntqugd09Gg71TDEDPlW2r3OfnVOBfMUV32f8akzHdYApBsoF/q tZmKWvXa6reazf8Kd13aNyz8xgHvJGEnd81SABlrnw2QS1D+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Fv0gnRkPaoQ5AGHyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwNxAoVxWIhc+P34m/WPk9gM47LJP0FdZK0p1g5Wmx4fcOZ7nmG/+Pz/kBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osif6xbLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTlrKAz3ATCroAVIDEQSniD++SYtkiVZotkA VJIpSpzlpFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLnIDRDNbdNtgvsY5QzUw3 3eDgtzyCDpg9raSTBq16bO8vT60fy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdJzb0x DybqTkksJ8ah8ULyqaT8EjOhnSnoZ2hZgQ4/BnNV2SpqAZwfpe4ZpeA4ELeq/1HKe6xR1yK7 SYsgNKV4qYIAI3lvC6QROQAGpm56vDDNyfT6XZ/Ep9k+zmz9nqLeYFL/Co4NEpvKtwDezLif AnUoww52XNIFH6jbKsyaYToDc0vlfLkDY69CqySacdSaJ9scgPB5DtpeUObw2Hqlg4rjL07P pCYN82rCB72FJha8dZ/fM9FuZdD+8z07TqMLXwn53xLCYajWUM=
- Ironport-hdrordr: A9a23:7Pso7qrcE+FekMUnz8cwyq0aV5s2LNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwOE80hqQFhrX5Wo3SITUO2VHYVr2KiLGP/9SOIVycygcw79 YET0E6MqyKMbEYt7eF3ODbKbYdKbC8mcjH5Ns2jU0dNT2CA5sQkDuRYTzrdnGeKjM2Y6bRWK DshPau8FGbCAgqh4mAdzE4t6+pnay4qLvWJTo9QzI34giHij2lrJb8Dhijxx8bFx9f3Ls49m DBsgrhooGuqeuyxBPw33Laq80+oqqs9vJzQOi3zuQFIDTljQilIKxnRr25pTgw5M2/9Vowl9 HIghE4e+B+8WnYcG2ZqQbknyPgzDEtwXn/zkLwuwqvneXJABYBT+ZRj4NQdRXUr2ImodFHya pOm0aUrYBeAx/slDn0o4GgbWAhqmOE5V4Z1cIDhX1WVoUTLJdXsIwk5UtQVLMNBjjz5owLGP RnSOvc+PFVW1WHaG2xhBgl/PWcGlAIWjuWSEkLvcKYlxBQgXBC1kMdgPcSm38RnahNPKVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBGB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehT9Yd3U8LAd23FFgMy4eFKyWhfzDGzG0vHQ7cn3O/erGM paY/ltcrjexWiHI/c84+SxYegVFZAkarxnhj8KYSP+niv1EPybigX6SoekGFO/K0dsZkrPRl 0+YRPUGOJsqmiWZ16QummlZ5qqQD2xwa5N
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/06/2023 7:52 am, Jan Beulich wrote:
> On 13.06.2023 21:47, Roberto Bagnara wrote:
>> On 13/06/23 19:45, Andrew Cooper wrote:
>>> On 13/06/2023 6:39 pm, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> On 13/06/2023 17:22, Andrew Cooper wrote:
>>>>> These are disliked specifically by MISRA, but they also interfere
>>>>> with code
>>>> Please explicitly name the rule.
>>> I can't remember it off the top of my head.
>>>
>>> Stefano/Bertrand?
>> Rule 2.1
> That's about unreachable code, but inside the constructs there's nothing
> that's unreachable afaics. Plus expanding "manually" them wouldn't change
> reachability, would it?
I bet it's complaining about the while() after the goto.
I can see why things end up caring - because this violation can only be
spotted in the fully-preprocessed source where the macro-ness has gone
away, and *then* applying blanket rules.
Which comes back to the original point I made on the call yesterday that
do{}while(0) correctness for macros is far more important than some,
honestly suspect, claim about the resulting code being somehow "better"
without the macro safety.
~Andrew
|
