[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/8] xen/riscv: introduce reset_stack() function
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Jun 2023 14:46:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OrzAVWHRC5m9R6tb1kW8qaFEfUZgMQ5RkPOtRv08TgE=; b=EftlSnMkAMG07Mzk6MTb+s4yPbAnmwNpGYn0w7/TgbsoWKCKU9jlSdpqe6RK6FbmliN5Kiulpu4I6G3XeBwHGhLpY9XmdXj+oYPm0xwnyzteOFcdCqGzxZ/rPm4xucWaHz1P9yzZtWZQDYF8olgAuExn0av5RJZGt6AnAScAEs7foMCJqmGnfPTXqfkRYu+FWlV/WWQZ/UG2HVBPeJOvcU2MKADD/IQ3lRPLBVcKzNffyXlK2k7b7mdY6vGstpayzwmm9t0+yWhXyp7WBfgucs2tQ60U0T9psmhGFUAxSTcFxYuKwe6J6uuegEmYIUfOAJl+f8fcdIl/Jh9VbNT0SA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iZUNLUYvtbwX7bZSVjzj0t7hrOx55jQCDC/7d40afAuCkeNNctjWtVYkDp9K3ZNLXkc83I5wGSq/UFomS1VIzbBCPsDp9Oi6a7ghnMCk7lEiM+gPDLZ2pRXjOcDGOjlyt0M3tgLiZ6Wu9jFtAJOia9M4w/+5tyfud6iWWXmTGv8++THEJTkRHinb5fVBo2E0wFTfsVL/h/DWz3bk9DMX96AOBLJvNePDke6BJi608WyxXqKJ/t3EiwjpdPjRqAGNW4mH1Hv+Tuj/v2Od3RFRn7xEzN8zOK8EdLSdtOFlVHS2bNQpCRBeEw4ywF5oPPah9euXIJXFj2dOAylSLwxZHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 14 Jun 2023 12:47:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.06.2023 14:19, Oleksii wrote:
> On Mon, 2023-06-12 at 09:12 +0200, Jan Beulich wrote:
>> On 06.06.2023 21:55, Oleksii Kurochko wrote:
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>>
>> This wants addressing the "Why?" aspect in the description. Is the
>> present
>> code wrong in some perhaps subtle way? Are you meaning to re-use the
>> code?
>> If so, in which way (which is relevant to determine whether the new
>> function may actually continue to live in .text.header)?
>>
> As I mentioned in previous e-mail there is no such requirement for
> reset_stack() function to live in .text.header.
>
> I think such requirement exists only for _start() function as we would
> like to see it at the start of image as a bootloader jumps to it and it
> is expected to be the first instructions.
>
> Even though I don't see any issue for reset_stack() to live in
> .text.header section, should it be moved to .text section? If yes, I
> would appreciate hearing why it would be better.
Because of the simple principle of special sections better only holding
what really needs to be there.
Jan
|
