[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen: fixed violations of MISRA C:2012 Rule 3.1
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 14 Jun 2023 15:28:19 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RmXONbex5w6RjBV0L7OFd3V9/VoMzl5BwyVFNh1Ct/8=; b=E1YUa43Mxx6/i1P60TDJaJe6DHaDC/0Q6Z1t6Pfv1BdSHnOuGZV0+P/9bPSPnmJr4OrJXW8sc3T2xJZF8OOFzGsgCZjX3VGfjxENFQiQEdG8qwdV1whScvv8M1TPw6FqI099ho23K3MwNrRPfbdt8YkKvvIAhgAK440O/NpQ/aQu7s/pYrl+zGAdBhmZMuL7nW24ZyCn9abNh8vdxmAyW1rt/aCCJd9X+7TAQq86MsA7gS7xpnBqcOz9BH7GXVft8KKVdZi8duKa9AqGHrYe0u8S0brYJ2mROET49k2c3ormq/m5OUZl1KQl86B01pLeJ8Z3rYEqP45hpzeFoSZvWg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j37PPFk/PmB7m0/Oy5TJ8qwQ1tFc+BwWgx6iKg7w4mTNbLtX2OP03Jml/cxrtpKtQtRFK4gMM9LiE07nAOCl63u7eSfUnouZrCK3DSHsLyZGmbMzX5BsuWNyUILcbv8txVS9OanMNjOhlh9S6uD5s8PrCBpP6LlsLrYx7b391pNSAsbJrLVyDc2WDY2HPPO+dKsrNpUQR9VGM4yq9zVy9QfmkfUbAO0+1MV8mVqbcIwVoGMKmpVOS9DxLGkony9YRAsC+BXs71Lyj5v+T9ruwHNsdlkUA8iurgVgF57zgWOLLtJIMGaQzB2sUlS8TbtVp/OfTMy85qN01ti92GiRWQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: consulting@xxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>
- Delivery-date: Wed, 14 Jun 2023 14:28:37 +0000
- Ironport-data: A9a23:P8A2lKz2YoXInRh4HG56t+d8xirEfRIJ4+MujC+fZmUNrF6WrkVRm 2YZWDvXafaCMWD0KdF1Oduy9ENUuMWDyN82Sgs9qiAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EsHUMja4mtC5QRgPKwT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KX5g5 eAYIjIvVBTZpcm93+KYS+9WgO12eaEHPKtH0p1h5RfwKK56BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVkFYZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqiAt1CSeLnqZaGhnXNmnYLBCI4dWKd//aZjhC1ZMtuC mwtr39GQa8asRbDosPGdxu5q3mAt1gCVsZKEus7wAuQxbHZ5QnfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESMSK3QfYTMFSwQt6cTsu4w1gVTESdMLOLWuktT/FDX0w jaLhCsznbMeiYgMzarT1VLahzOhoLDZQwhz4R/YNkqv4xllfoeja8qt4ELC8PdbBI+DSx+Ku 31ss/aZ6OcCHJScjhunSe8GHKyqz/udOTiaillqd7Ej/Tmw/3+ofahL/SpzYkxuN64sZjvBc ELV/wRL6/d7JnKqcKsxeIO3BMQCxLLlU9/iU5jpgsFmZ5FwcEqL+X9obEvIg2T1yhBwy+c4J IuRdtuqATACE6N7wTGqRuAbl7g22iQ5wmCVTpf+p/i67YejiLeuYe9tGDOzgioRtstofC29H w5jCva3
- Ironport-hdrordr: A9a23:NgtPMqHTihPyFK7UpLqE0seALOsnbusQ8zAXPhZKOHtom6uj5q OTdZUgtSMc5wx7ZJhNo7q90cq7IE80l6Qb3WBLB8bHYOCOggLBEGgF1+bfKlbbdREWmNQw6U /OGZIObuEZoTJB/KTHCKjTKadE/OW6
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/06/2023 8:42 am, Nicola Vetrini wrote:
> diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c
> index 75bdf18c4e..ea6ec47a59 100644
> --- a/xen/common/xmalloc_tlsf.c
> +++ b/xen/common/xmalloc_tlsf.c
> @@ -140,9 +140,10 @@ static inline void MAPPING_SEARCH(unsigned long *r, int
> *fl, int *sl)
> *fl = flsl(*r) - 1;
> *sl = (*r >> (*fl - MAX_LOG2_SLI)) - MAX_SLI;
> *fl -= FLI_OFFSET;
> - /*if ((*fl -= FLI_OFFSET) < 0) // FL will be always >0!
> - *fl = *sl = 0;
> - */
> +#if 0
> + if ((*fl -= FLI_OFFSET) < 0) // FL will be always >0!
> + fl = *sl = 0;
> +#endif
> *r &= ~t;
> }
> }
This logic has been commented out right from it's introduction in c/s
9736b76d829b2d in 2008, and never touched since.
I think it can safely be deleted, and not placed inside an #if 0.
~Andrew
|
