Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

[Julien Grall <julien@xxxxxxx>]

Hi Ayan,

On 15/06/2023 10:29, Ayan Kumar Halder wrote:
> On 15/06/2023 09:05, Michal Orzel wrote:
> > Hi Ayan,
> Hi Michal,
> > On 02/06/2023 14:07, Ayan Kumar Halder wrote:
> > > Restructure the code so that one can use pa_range_info[] table for both
> > > ARM_32 as well as ARM_64.
> > I grepped for ARM_{32,64} in our code base and could not find any use 
> > in source files except for things
> > introduced by this commit. While I'm ok with it in a commit message I 
> > think for consistency we should be
> > using arm32/arm64 in the code.
> AFAIU, arm32/arm64 refers to the Architecture. ARM_32/ARM_64 refers to 
> the configuration.
> If you see the original code (xen/arch/arm/include/asm/p2m.h, 
> xen/arch/arm/p2m.c)
> ARM_32/ARM_64 has been used.
>
> Thus, I used ARM_32/ARM_64 in this commit. Let me know if it makes sense.
> The rest of your comments look sane to me.
In text, we commonly don't use the name of the config. Instead we use 
the name of the architecture (i.e. arm32/arm64) because this is a strict 
correspondence.
I agree with Michal, about using arm32/arm64 rather than ARM_32/ARM_64 
in the comments at least to stay consistent with the rest of the code.
Assuming there is no other changes required in this patch (I haven't 
looked at it yet), then I am happy to handle this request on commit if 
you are OK with it.
Cheers,

--
Julien Grall