[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] xen/arch/arm/traps: remove inlining of handle_ro_raz()


  • To: Federico Serafini <federico.serafini@xxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Thu, 15 Jun 2023 16:49:59 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bugseng.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/PSe3wL1FlX4SRiiVy+oQUs2Fn1Y5kSvri+Me8B2+8s=; b=UG/YoctD2buf/z0sHIiCR/dHKXBtQQwewZ97v8kZ9Ecvasp4MgJfAhig+TKPXT1DdyMcjNCFORGs78jgXQZEfRnNVma8AYFyozyXhWOD8AA0soAlvSpOxfnKmUM9+EgY28/dp2oPqfIrTpFOk9Zxf94I2aR8L+ByLTlTo6D67b+rC0Q2uI8uXuPFKK1R+76E12qf+ex3S7HtUSn0wauudmhJ3dF6YwAuiidXnmpDH6xvcyNOiqbvPLG2j2oNnwATF9ts/hXvJ0WWrcCXYfYQvM0pLwZk6tcP23tD1YT+AqOVbZJ4HrAQn42E3GNrXmVQr61VzwndvuRjqX0lo4BaSw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GuzXXBjtzys7TlIGEnPOHqaZ3ELpPH9pl+9X+WUFxNa5a2BMVVRwZodEtMs3j9A7Otww4d3QrI9uefZJaNSLliqjdqLSPkgTMKF26Xl01Y/cQRwwGN++GiCOZCcTpsa1BbePFYoeT8RpqJlQWP+xW0Wz+OT78maX1FsRYn1Rx47LsD9jdcQnf9e3nyjg2B/VLd1thEG2bv8dUDuHZ/HGbsk9WJt1TSFC3JAVnsxZaddlmfsjTzO6crjioGrpVaZQVubUxiUqw1ziqfHHi11BQOlONqAAgTXgdKxjamePQqS+6wdHvR3As3PCkupCuOGoXOtRqIWx3kBh92w+t1mzcQ==
  • Cc: <consulting@xxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 15 Jun 2023 14:50:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Federico,

NIT: for Arm, we use "xen/arm: " as a component name in a commit title or if 
you want to also specify
the sub component, then "xen/arm: <subcomponent>: " e.g. "xen/arm: traps: "

On 15/06/2023 15:50, Federico Serafini wrote:
> 
> 
> To comply with MISRA C:2012 Rule 8.10 ("An inline function shall be
> declared with the static storage class"), remove inline function
> specifier from handle_ro_raz() since asking the compiler to inline
> such function does not seem to add any kind of value.
> 
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.