[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] xen/arch/arm/traps: remove inlining of handle_ro_raz()



Hi,

On 15/06/2023 15:49, Michal Orzel wrote:
Hi Federico,

NIT: for Arm, we use "xen/arm: " as a component name in a commit title or if 
you want to also specify
the sub component, then "xen/arm: <subcomponent>: " e.g. "xen/arm: traps: "

On 15/06/2023 15:50, Federico Serafini wrote:


To comply with MISRA C:2012 Rule 8.10 ("An inline function shall be
declared with the static storage class"), remove inline function
specifier from handle_ro_raz() since asking the compiler to inline
such function does not seem to add any kind of value.

Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

I will update the title while committing.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.