[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0.5/2] x86/boot: Clean up early error asm
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 19 Jun 2023 10:10:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5FUWPbGmB7Bc/TzM5cS7jf1DQiSsN6IzYdX7GZ8v4cc=; b=oS+0khi7KjrdRlOq3gHes0fdtUYqrGw7z5YoA0+Qw9o3fYZRYkT4BWEvIa9BrJ/rkkADAYxupUjibeG/LNAf/dQD+ReZH4KMe8Kr8ndxxb5IppaOjYMVypTNwQqqNrQ9oAdBsLl7dWOIZ8TduIpq6C+BHA2LA8kNUd87q/JaroR0L9SSr8+T+uYwain7BPMF2hiFZ/4Ah9kZkw7rjN7k7mqEBn3CP7rlnJLsvCEzg3W5/OFd9GTSPLV6wNCMrhhNdwCPAqatz7l8T3I86dSoQPL45pPUo0kw4PaqR807ztSsz2C+TZYxp0LhrIBvAKjEQkYglV73CPhinD0nf+i1Ow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=msQSZyzr988oAbNq90X3lxDUxRUXLktDIQP9/C3WpRTXdoFxMUk6Qx/kwhQp46nU4L9orXZ5VDrma9msNQh6OnOqjZu9PcHl5KoJaxDFsKx9RPoBKuUyYCkm2whtMPkOf18OFx0jUXmCZsHygri/di1vHxKc+hi9ghZCd9U0m2sMpf0YjKw5MJFGhLEZunFEEyw/EDUSsKtNSXeD83qJEkz+sxdcxGphHuKjAxXqwyvfsXIaRHW0ppJszAZMQy85QS6fu1A5PM1mIh+EZYFTiJXDVELMvlRCaK+PbKpnpbsjRbOghcD3NcQffc6R6c4YabD9TZYa0giJvHqVQrSdsA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 19 Jun 2023 08:10:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.06.2023 20:23, Andrew Cooper wrote:
> The asm forming early error handling is a mix of local and non-local symbols,
> and has some pointless comments. Drop the "# Error message" comments,
> tweaking the style on modified lines, and make the symbols local.
>
> However, leave behind one real symbol so this logic disassembles nicely
> without merging in to acpi_boot_init(), which is the thing that happens to be
> immediately prior in my build.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one request:
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -142,25 +142,27 @@ efi_platform:
>
> .section .init.text, "ax", @progbits
>
> -bad_cpu:
> - add $sym_offs(.Lbad_cpu_msg),%esi # Error message
> +early_error:
This symbol, which isn't really used except by .size/.type below,
could do with a comment saying that it's intentionally here despite
having no real reference.
> @@ -202,6 +204,9 @@ not_multiboot:
> .Lhalt: hlt
> jmp .Lhalt
>
> + .size early_error, . - early_error
> + .type early_error, @function
At the 1st and 2nd glance this looks unrelated to this patch. Which
isn't to say I'm opposed, but of course once we have settled on an
annotation model, it'll need touching again anyway.
Jan
|
