[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0.5/2] x86/boot: Clean up early error asm
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 19 Jun 2023 12:20:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EBldFb2h85UZpSgEFUhgy2KcvqJfpmyjslBP/tMBoXg=; b=AOzuE2bZPAvWs+21OG1K3RqxNTqhWgdMn9iXSwqlIHoL6qs4o4wtu1XWCJxIl5TKzE1yZ+3K1q+o/syjiqBKlSFEw1SKpufAgP5NT4EdnzGIEra3enO2B4wDyrGq0ijEL1fvcHnswRYhJMt9jug3kP2viLhORbIW+Bf7CvPqUNZjcpM28AGKjnyym46PqJczkWR1xy8RLxSMxGiL2jK8cAUlvIhMO0bT/oyb/lsOoM3It5iGiC94ifXNlhrWYeSSNcZJALK/qWTPGSsNWMQt2nZaKlRpCctCqsNUyyhjCFSU2UqTd0t7yyIttwlQHcI6wg8vgrpOOilyeDzg/3XpWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jTxJEtcMDOzw8w4pMSmzN/hkeeypJYVEHoecGiu3MrHj+QaY7CgVr2AVc9vGqRco8W0yN3xvuAFao7euu1E1J/TZNY8ubiCmxW/rEOaZjGD7g3WfzsCq93hU7+ehpsmEj1DMwsqub77klwSLpNMp46a075mH0uLkV8CXfjf9B1cLwzUvN1354oR8uC3c/jwpYiLsU81PRt0Bs8RFfp3dBWKhy3M3e8OSLq50ekRsCz6Qmpet8WfV10Fkp7mMf2p4cydl2QSsuxiXz5qykKwedBocZ5DYlnNOXfY3+V+DXb+Lchn23B/qgEtiE+E+b8Pyq491kaod0OaQi1+50fh9eg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 19 Jun 2023 11:20:27 +0000
- Ironport-data: A9a23:0MkSm6tQG0AjiSHhbxqZyBsASOfnVJZfMUV32f8akzHdYApBsoF/q tZmKW3VbK6KYGamLohzbYmx/E4F6pLXx9dlGlM9pS89Ri9A+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Fv0gnRkPaoQ5AGHxiFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwdxVTQlOo38uM5J26ddBGn/sELeL7FdZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4W9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOThrKAx0A3DmQT/DjVVElCno6SJu3WGBcBdE A9I2y1wtKMtoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQj0 lKLltXlHzsprrSRTX+f8Z+fqTSvNW4eKmpqTT8JS04J7sfupKk3jwnTVZBzHaitlNr3FDrsh TeQo0ADa647iMcK0+Cw+gnBijf1/5zRFFdquUPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytalUwXXYH80EdygmQ
- Ironport-hdrordr: A9a23:geah26omuX+k9pB7GBZZyKMaV5pIeYIsimQD101hICG9E/b5qy nKpp8mPHDP5Qr5NEtLpTniAsi9qA3nmqKdiLN5VYtKNzOLhILHFu9f0bc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/06/2023 9:10 am, Jan Beulich wrote:
> On 16.06.2023 20:23, Andrew Cooper wrote:
>> The asm forming early error handling is a mix of local and non-local symbols,
>> and has some pointless comments. Drop the "# Error message" comments,
>> tweaking the style on modified lines, and make the symbols local.
>>
>> However, leave behind one real symbol so this logic disassembles nicely
>> without merging in to acpi_boot_init(), which is the thing that happens to be
>> immediately prior in my build.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.
> with one request:
>
>> --- a/xen/arch/x86/boot/head.S
>> +++ b/xen/arch/x86/boot/head.S
>> @@ -142,25 +142,27 @@ efi_platform:
>>
>> .section .init.text, "ax", @progbits
>>
>> -bad_cpu:
>> - add $sym_offs(.Lbad_cpu_msg),%esi # Error message
>> +early_error:
> This symbol, which isn't really used except by .size/.type below,
> could do with a comment saying that it's intentionally here despite
> having no real reference.
Ok. /* Here to make the disassembly better. */ ?
The .Lbad_cpu jmp will end up disassembling to early_error+0, so it is
technically referenced, but I see your point.
>> @@ -202,6 +204,9 @@ not_multiboot:
>> .Lhalt: hlt
>> jmp .Lhalt
>>
>> + .size early_error, . - early_error
>> + .type early_error, @function
> At the 1st and 2nd glance this looks unrelated to this patch. Which
> isn't to say I'm opposed, but of course once we have settled on an
> annotation model, it'll need touching again anyway.
I know it's going to need changing, but in the short term I'm at least
making sure the metadata is correct on new additions to asm code.
~Andrew
|
