[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/7] xen/arm32: head: Add missing isb in setup_fixmap()
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 20 Jun 2023 03:06:39 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iP5NrzmbrQmiTxSeJcYrmBjGHBt8szUrwWyfRndvOv0=; b=QzSD+bYAQstER6SrPINoZz/nKTIMKYlqo5IH2Aan398jlFgknHORPj9iZZsBqOo6Vhqf3uQvrUL1w8jrANbmoum9+a0pP5NTLmCoRVoz+khL6R9NHCUbh/2OtcwJt3rzQrTjBDdQ9Na4y/RKj0lFYzbZliXXhMjzFue0/7oB4D4FpQPDmksbRDXAtHA+3cGbEKMMVeJqoZmhJnlxuUZpMI508lh3OeReJDaVUAedMnQVuW41xheNnjLkY0dOvu1Bjhmt5/PCFFX1vHidcjETkY84lhyqxQLrez6GuGfOc551LC2ZKm+wC0xbPp5LmdyfVK8yMEhxZn1NyVU0gtCVIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWDcyXOJ4lRHdO6Zmr8sSZwaO2OwfHyTOhuTOggRTT9Cx2KRqL4rKclUZ6g6trrSLnwXcBUG66kLqPYi0vlK8VRjFoL3gg3jEvTv75VSxSCbhGQeigr/YU7NNjGp04k2vrHxg2ge+o7/szCph3i0nYcBD49VW8S5JE0u957uTwrg50rim/cj1a+D8LTTFTcdIZZmdq2XcpPoxRJhF6tmemIdndModwFgIVtSP28VHPxr2kvmJGM80gxnEh7v9vOLcK5ZiinH1oa4BfV0iJf4khDIAlE0ioiUbDhzQD+scJLvsTXwGtj7oEhNGUx79g9ywwgRunhDTLqKrvtbIKUgoA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 20 Jun 2023 03:07:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZos+2ltfg5NgjVEuuwuFzD+8iLa+S1BNw
- Thread-topic: [PATCH 1/7] xen/arm32: head: Add missing isb in setup_fixmap()
Hi Julien,
> -----Original Message-----
> Subject: [PATCH 1/7] xen/arm32: head: Add missing isb in setup_fixmap()
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Per the Arm Arm (ARM DDI 0406C.d A3.8.3):
>
> "The DMB and DSB memory barriers affect reads and writes to the memory
> system generated by load/store instructions and data or unified cache
> maintenance operations being executed by the processor. Instruction
> fetches or accesses caused by a hardware translation table access are
> not explicit accesses."
>
> In setup_fixmap(), we write the fixmap area and may be used soon after,
> for instance, to write to the UART. IOW, there could be hardware
> translation table access. So we need to ensure the 'dsb' has completed
> before continuing. Therefore add an 'isb'.
>
> Fixes: e79999e587d7 ("xen/arm32: head: Remove 1:1 mapping as soon as it is
> not used")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
I've also tested this patch on top of today's staging by our internal CI, which
includes the FVP arm32 mode and qemu-arm32. Our CI says this patch looks
good, so:
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
