[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] xen/arm32: head: Add missing isb in setup_fixmap()
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 20 Jun 2023 11:10:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xxI3ahc9f6N1b1z/2T3j1kAQUzLL0OmOAOwewfY/PVw=; b=AbWsqJM6hKIlQZt5tuGINxnNc//uvBJvBXe21UjP4RaRrR/YzK6h8w3dORm4NXr7O1a2fbu/58yqVYxUYbdz3mLyAs9s1p8SJaqfIitzC2OWF8gZlKUvhBaEa5QksGFEbCgLAbPphbpE5YJPpFaj71spCtlTuXs2ttjdjUrurv8Fx2SlTHpxhZUJI/jWoafFCwsfWIbFL72PQwg59LSp1CvsRM+yi1+AY4RpGMN81Ppb+ThnLVlIMY3IWv+mY9r/9MzeGmSkLjeX4yAs8jQ/+gUMi2q0dBWwqUfZe111eBmwlkEnpMNeMMpuwgIc9KxXHsZ07CBJEVGSAlW9IKEV/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQR5c0EUy8aaJP5RxA9Ex7yx0t0F3BYiND6djq47lW1TywUALlBXn6koauj27FsWtfegihaRIG4SpfdPBiWfBri8Rfu5HPeRM8qIP4IoCFUJ+jQOug8YC/hhvb549kj+qFQpuNBe0fLSbcEmDAU8gz63tOozlVPuBvcrNasXbxAHgQTeqsVUyWa7C9tUO3Q/hEhLL6T7ZNJeT+8agrspbLBdHppV580T5QM+7DoQMZ9nLclL0NiewEsMZxQQAqEqNk15CfLojjd4WUdR52gVcI8CDb96xwN2OmOJpXAOqDfPYNWj0an/7YHyLlHQbTzlGTjWw35bkwswJ0VoMDhe0Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 20 Jun 2023 11:11:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZos+4j3GmbsysAEGR9uy2Puvqtq+TihkA
- Thread-topic: [PATCH 1/7] xen/arm32: head: Add missing isb in setup_fixmap()
> On 19 Jun 2023, at 18:01, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Per the Arm Arm (ARM DDI 0406C.d A3.8.3):
>
> "The DMB and DSB memory barriers affect reads and writes to the memory
> system generated by load/store instructions and data or unified cache
> maintenance operations being executed by the processor. Instruction
> fetches or accesses caused by a hardware translation table access are
> not explicit accesses."
>
> In setup_fixmap(), we write the fixmap area and may be used soon after,
> for instance, to write to the UART. IOW, there could be hardware
> translation table access. So we need to ensure the 'dsb' has completed
> before continuing. Therefore add an 'isb'.
>
> Fixes: e79999e587d7 ("xen/arm32: head: Remove 1:1 mapping as soon as it is
> not used")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> ---
Hi Julien,
Yeah makes sense!
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
