[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/7] xen/arm32: head: Add mising isb in switch_to_runtime_mapping()
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 20 Jun 2023 11:13:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aZef6VQ5OMKe2lFfqTjtfZn035cXlTUU857V3XnbV2Y=; b=F9CQG79yYnagfjfZFbYaLENSGgX/SxGz7ShaoE2LBf4H8VpQx8awPRE3MFU+yFa5GtCK0SqN1HUKBYJaGPoBPKO4/Vtzh0EUqKx9CWiev7vuM5f2NO3ua28P2kSAk+TGuk5JvbCPBt0Qy1kyTjK15PARsQjwSkMFtHoSXNziXleiotoAwRcnHf8lKNzYezvx3JBsZ287hQcy5jPc+BWlegyG3Lcru2pkscVzczzS8zTZYHYcpfY08p9yynBY5HP2/7AdQvUMB4KKAbOwPAg2uN+fpgpIJQ1hdQsrcasiX/TkfpWYBz0ifww76wOLtaY+LSXRVKGkyXplq4MPZe4yAA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Unpcmal/VfkT1aGB2JcyS4gT/m7KRfljdzIS9qYtgWXetlypjoa6ADyxX8SWDC90bvSu1H8Nj4S0HJ2Ka/fx3yMxPIsYr31xPyiDwVVC+yqAqX9oK276XwmvSYeXdPEcpsa2H5LyKov0+ujruWx69Rcu10OiFhx33u4qkWLI56/F8ESIfifo6fKSNbhY3iUgY+4Xvm2QqmYCKxKMOKKdBx6Vn8UwTkhxhSN0wX7IPjimZn8Eot+r+AaTRYqrezKplY5UG93YXLZBnHG5nDRZIhsf8FK6hgLm9kBR7cKTJ7e+pq4ScO3pU3/9GMPlxzsJHfUdaQ9fSXcTVLQmRmvkPg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 20 Jun 2023 11:14:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZos+1Ygxb/Hk/1UKuP2FBGOpYia+Tit6A
- Thread-topic: [PATCH 2/7] xen/arm32: head: Add mising isb in switch_to_runtime_mapping()
> On 19 Jun 2023, at 18:01, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Per the Arm Arm (ARM DDI 0406C.d A3.8.3):
>
> "The DMB and DSB memory barriers affect reads and writes to the memory
> system generated by load/store instructions and data or unified cache
> maintenance operations being executed by the processor. Instruction
> fetches or accesses caused by a hardware translation table access are
> not explicit accesses."
>
> The function switch_to_runtime_mapping() is responsible to map the
> Xen at its runtime address if we were using the temporary area before
> jumping returning using a runtime address. So we need to ensure the
> 'dsb' has completed before continuing. Therefore add an 'isb'.
>
> Fixes: fbd9b5fb4c26 ("xen/arm32: head: Remove restriction where to load Xen")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
