[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/7] xen/arm32: head: Add mising isb in switch_to_runtime_mapping()
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 20 Jun 2023 03:06:43 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=54iKH+sycYsQbNuMSIEdX+wzjrK9Dcz3t9e4c38UQ4g=; b=C5TUgk6cvqgNZhK0N3Ve/sfojKmPeiQ42xeY9WWriXNJlHpnT3uJiwvhBlcCNd5KdOHHEBwexMRGMroHni0CYZ0PCHwgJZ1jr95eMYU1SMMpsGAcMnezAetdaM+N/sgAQBFku9FVgUPaR5LzsAJIcCfBYCToIjYS1WWTBtqJqN4xw/o2ezVhIV4Rgkw2mJeob8TVeX+lC1ti2R3Jf4tZWc+vsdDX77woyeiiRsy19B+K9YOeJhGrfoToeMMs2NqirCXDigNbPRgGkxth8GwVkRIS6pSkgEq5u57H/1uh182ewpB3yG4FN4qVQ4VeuqFyrUeN3UflSNlQu3qFefa/7g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m2fsE0W6+ds3C2nxUaWWFIOhgrlZ/nFcaSp194cdjilmaMX51Esu2QTOypEEgSaZ6jFxdvUmNFgrYgNteorZTcdPikYnovAcizwQKYb6GokYgWGfWWnWZLf8i0t9xZ/mon59cHc5YSLLLQ363uLEDy2xtkQioOSM3HxoVt2hDOTgMi833dgNdA9QNIMR6oOv92PQ+vG28zgHSlJ5UDr2ZQL68e70eU688yfgD73iAKCfWYvcktcEvc0nZ41KD5dPLgAfKoWsLN1gynyg5GDMcCzLtN2TjWzXMzfRoIuFbdVpTx5q2IBpQ9r4zwah1KmbXL8wz94xMAcmz5UCiURwVw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 20 Jun 2023 03:07:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZos+1XyHwqUM4b0ab7XTMNqCqhq+S1PQQ
- Thread-topic: [PATCH 2/7] xen/arm32: head: Add mising isb in switch_to_runtime_mapping()
Hi Julien,
> -----Original Message-----
> Subject: [PATCH 2/7] xen/arm32: head: Add mising isb in
> switch_to_runtime_mapping()
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Per the Arm Arm (ARM DDI 0406C.d A3.8.3):
>
> "The DMB and DSB memory barriers affect reads and writes to the memory
> system generated by load/store instructions and data or unified cache
> maintenance operations being executed by the processor. Instruction
> fetches or accesses caused by a hardware translation table access are
> not explicit accesses."
>
> The function switch_to_runtime_mapping() is responsible to map the
> Xen at its runtime address if we were using the temporary area before
> jumping returning using a runtime address. So we need to ensure the
> 'dsb' has completed before continuing. Therefore add an 'isb'.
>
> Fixes: fbd9b5fb4c26 ("xen/arm32: head: Remove restriction where to load
> Xen")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
I've also tested this patch on top of today's staging by our internal CI, and
this patch looks good, so:
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
