Re: [XEN PATCH 1/3] build: define ARCH and SRCARCH later

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Wed, Jun 21, 2023 at 12:20 PM Anthony PERARD
<anthony.perard@xxxxxxxxxx> wrote:
>
> Defining ARCH and SRCARCH later in xen/Makefile allows to switch to
> immediate evaluation variable type.
>
> ARCH and SRCARCH depends on value defined in Config.mk and aren't used
> TARGET_SUBARCH or TARGET_ARCH, and not before it's needed in a
> sub-make or a rule.
>
> This will help reduce the number of times the shell rune is been
> run.
>
> With GNU make 4.4, the number of execution of the command present in
> these $(shell ) increased greatly. This is probably because as of make
> 4.4, exported variable are also added to the environment of $(shell )
> construct.
>
> Also, `make -d` shows a lot of these:
>     Makefile:39: not recursively expanding SRCARCH to export to shell function
>     Makefile:38: not recursively expanding ARCH to export to shell function
>
> Reported-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Tested-by: Jason Andryuk <jandryuk@xxxxxxxxx>

Things are back to normal speed - Thanks a lot!

-Jason