Re: [XEN PATCH 1/3] build: define ARCH and SRCARCH later

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Jun 22, 2023 at 10:15:42AM +0200, Jan Beulich wrote:
> On 21.06.2023 18:25, Andrew Cooper wrote:
> > On 21/06/2023 5:19 pm, Anthony PERARD wrote:
> >> +
> >> +ARCH := $(XEN_TARGET_ARCH)
> >> +SRCARCH := $(shell echo $(ARCH) | \
> >> +          sed -e 's/x86.*/x86/' -e s'/arm\(32\|64\)/arm/g' \
> >> +              -e s'/riscv.*/riscv/g')
> >> +export ARCH SRCARCH
> >> +
> >>  export TARGET_SUBARCH  := $(XEN_TARGET_ARCH)
> >>  export TARGET_ARCH     := $(shell echo $(XEN_TARGET_ARCH) | \
> >>                              sed -e 's/x86.*/x86/' -e 
> >> s'/arm\(32\|64\)/arm/g' \
> > 
> > The change looks plausible to fix this issue, but could we take the
> > opportunity to dedup the sed expression into a $(call src-arch ...) or so ?
> > 
> > Except, given that ARCH := $(XEN_TARGET_ARCH) now, doesn't that mean
> > SRCARCH is always TARGET_ARCH ?
> > 
> > Can't we simplify this to just be plain aliases?
> 
> Or, putting it differently, do we actually need both TARGET_* values
> when they match other (exported) variables anyway?

Sounds good to me, I can remove both TARGET_* variables.

Thanks,

-- 
Anthony PERARD