[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xl: Add escape character argument to xl console
- To: Peter Hoyes <Peter.Hoyes@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 22 Jun 2023 10:12:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QLknlhEza6pSoQOsSZg5HZmuUJaYWE/0deBbNcnWdjI=; b=alRhNhDUX2nUwUy4LQhRin+5EseyLqrrWMA44MOrwaF1cLJ+IfO6UeDZcKvSWlJZHj9R+lwPUz1o/ZKhDwEiZ4ZNq7RA2vxJMxSsvprsM4xWUuTkh0bbbI8SOIAuNro28YhO/TAKmnEJTr0DDwdcqs6AcvTeFxHkqVLRDldigDWNUy7gAdjpwfgUH11bJYKW/XI+CsEK5XJjmkFUfuRqR+OyYqkehK2bekPUgWcSBZ/CPA0abhe/YyWQCoumrtqqVkVqLZFvLGFHrWtEsSyUCBf2FpalTszp5CmR+rj8ovBQqs/zBIKBYNS9QpcseFqhZo5haXPhf6hDZMrKu2AUQQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKZBL0LK9r5nIqpsxnb5MW+wAzlTEir2/zLv1XKF/0SDqy+WUI0RlyATUniE4H7fPV4kCuY9X7hj6kcE4s+3C5gJXxWbTVvLSkJ+dmvl/vXonoTQlp34aGiP+J5P+uCz75McCU14EOiPblHChyisn+AKxKZCqke9GXocHo+r/rwchog7dH+Xa3m6X1+UOsKbizqM1/AgDLet5eTIWuasr2+vdWRrSuAXISC4MdFdz9gnMoOaYqo7gce+b+vBfFHtGbU9nDTTc3G525xO3QiR//ZFdd38YTU6p8LDwPJ5Yf3yqcEE+LjP/smcpcpDSwDtIJs6rp0Uy2LhwtwvnYsSsA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Thu, 22 Jun 2023 10:13:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZpPF4K+MH8OHsUk+nQoVxITkfyq+WmkCA
- Thread-topic: [PATCH 2/2] xl: Add escape character argument to xl console
> On 14 Jun 2023, at 08:41, Peter Hoyes <Peter.Hoyes@xxxxxxx> wrote:
>
> From: Peter Hoyes <Peter.Hoyes@xxxxxxx>
>
> Add -e argument to xl console and pass to new escape_character argument
> of libxl_console_exec.
>
> In libxl_console_exec, there are currently two call sites to execl,
> which uses varargs, in order to support optionally passing
> 'start-notify-fd' to the console client. In order to support passing
> the 'escape' argument optionally too, refactor to instead have a single
> call site to execv, which has the same behavior but takes an array of
> arguments.
>
> If -e is not specified, --escape is not passed to the console client and
> the existing value (^]) is used as a default.
>
> Issue-Id: SCM-4958
> Signed-off-by: Peter Hoyes <Peter.Hoyes@xxxxxxx>
> Change-Id: I80ffbb7fecc63e023ec1c7f1e4ad7979ccf8da44
Hi Peter,
Here in Xen-devel the patches should not have Issue-Id and Change-Id,
they can be stripped on commit if the maintainer is willing to do so,
otherwise you’ll need to send a v2 with the tags removed.
To me the code looks good, still need a maintainer review though.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
