[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tools/console: Add escape argument to configure escape character
- To: Peter Hoyes <Peter.Hoyes@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 22 Jun 2023 10:12:29 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1ASqtiFG2OOGD2Vw1Of3qidX72CHEs9F+6fAFU5tT44=; b=VQ6oqtIMxCil1XG3FDx1kHV915Az32gB06PLhrpRvP97r7WsFA4UB6g1Fh9raJpDauf+WeWyoTJ/yxFRL2NAa+DVDzCuJgw6WFxqlP1BQCLpHBqpCKAp2yIDBFvgHoWcKCZLs3jUPoURTtRAovv3/GNO5xTZah8ZuJhRRDvrZtmPrup+joMXAi2mfkd+rd2gKsUdWA55WJ/alMlaR9caSl2waDTJgM25eOA/vG9iUVtBnmm1wgkWEvrn+JCOmri8ycpujsjD14hKkP9KGlBNsy+6/hTTtab930shtpvMsZf21Jmh4D8r58w1rjvlqtBGWWJSvvhEtAYd2vkYyfpZiQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VWgBLIUaFd89FW2Ll8L9naeTYhLkVor0WnTY24Vj7LgNPezMYLWu6s31fB50/1W5G6kSjj6KtgRTMk/lBv2R/mKgLHOCE33FpuDW1v1rAAQDJoEVjj+v1Zsk6n+A0f3LXPfYYambtFSKQRvuOhWNpKBoePSW2MM5K04Yu4i0m9UYyN9RAq7pP8+ST6+OVLF+dO0yE4q5E5UwRO3PaXYaw4lKpO+g5Ljm/Mb4WoV32X8XocBOxopBAuk/lxWtwKQYRJ0uMExC+LzW7ZQaPogVZF0y2pxxOBf1gizq60UhhpmcqonG2pI49dV/RsqweRMvAwPInOoejMBBcS2Q40TE/A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 22 Jun 2023 10:12:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZpPF3QpbD+YTBNUSeBQYgOGD68a+WmikA
- Thread-topic: [PATCH 1/2] tools/console: Add escape argument to configure escape character
> On 14 Jun 2023, at 08:41, Peter Hoyes <Peter.Hoyes@xxxxxxx> wrote:
>
> From: Peter Hoyes <Peter.Hoyes@xxxxxxx>
>
> Dom0 may be accessed via telnet, meaning the default escape character
> (which is the same as telnet's) cannot be directly used to exit the
> console. It would be helpful to make the escape character customizable
> in such use cases.
>
> Add --escape argument to console tool for this purpose.
>
> Create parse_escape_character static function to convert a character
> string (which may include a '^' modifier) into an ANSI integer.
>
> Add argument to getopt options, parse escape character and pass value
> to console_loop.
>
> If --escape is not specified, it falls back to the existing behavior
> using DEFAULT_ESCAPE_SEQUENCE.
>
> Issue-Id: SCM-4958
> Signed-off-by: Peter Hoyes <Peter.Hoyes@xxxxxxx>
> Change-Id: I3795e654b382e78144d8210f303e3ebccec457ed
Hi Peter,
Here in Xen-devel the patches should not have Issue-Id and Change-Id,
they can be stripped on commit if the maintainer is willing to do so,
otherwise you’ll need to send a v2 with the tags removed.
To me the code looks good, still need a maintainer review though.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
