[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/types: Rework stdint vs __{u,s}$N types
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 22 Jun 2023 10:42:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ya5OBKa4U4pXsz1gQtJ+XEYBNA4mQKe7sGf8wtHMzhs=; b=EzsEzyaBrV1yx8yf1Rtx+r4qYSLXVD5XxvxF6HO7kuslAHAyTMeys4RmwaDBL8PcpABotMvw6u52azkcMU8eKN09mZ0sKupxvNc6VeGwZTJBZpXAQDoE0CYpf+mqlnqcU9W/DXHRFhM5t3SGdceE0EiHzjEtwv+/fMgcw9G8Cmbw0UQGgw2FiKMroLFk1SMiKOIJ7XtaMf6FxZStexAcDZbw/uTpFIDz/aIK2XC6vFXk+JWf7Utlb443Plx38wFWwrZVjOp+zRwlUttLRgJS5jdpf/pdC2+KsOQRriEc5s5VRmihYS5V6Md2rfuMICd8TokKMOMEPQ4IedcWFDgNhA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WHzcTsWZ+FbuA+ulL7DmUrmXM8KfiKH+hJ3xLGK7z2Au1fvtW+00ASKdZZlaJahdI4oSn4+AXatjkaCDFT/GdYtv/me+9O8C7Sx0FY2IDD8MtNDPjydB1K+xkQLwy04BOIC5zNu2YTCjizNijIpkT9gwAfmyufr/3Rq2ZGfmRo//JNiBT3AAINKg79BvLqnZG1UNflr0ln54p0+Fyk//EAiwt1eH/6G/tPz0+qGQfDqXiBrZc8qzmVG8umh2SA/Je8vt7hCGIah75f1c/gisL2mjZYINygqxtgx9++gbIUyMv2RkTpGqXchy/WXoGXVzERklnPiotGJMepQJlyCh6Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 22 Jun 2023 08:42:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.06.2023 23:12, Andrew Cooper wrote:
> A different option would be to sort out the stdint types ahead of including
> <asm/types.h>, which can either be done by introducing a <asm/stdint.h> or
> upping the minimum compiler version for x86; a task which is massively
> overdue.
As per my patch moving in this same direction, I strongly think this is
the direction we want to take. (I don't see a reason to introduce
asm/stdint.h for this - the logic you put in x86'es asm/types.h can
well be put in xen/types.h as well, suitably limited by a slightly more
involved #if than you have it now.)
Personally I think using "mode" attributes for the fallbacks would be
the more widely compatible way, but I'm not going to object to your
approach avoiding them. It would feel more safe though if without using
that attribute the fallback wasn't tied to __INT8_TYPE__ being defined
(but instead directly to being on very old gcc).
As to upping the minimal gcc version for x86: While I'm pretty sure I'm
considered the hindering factor here, I continue to think that my
"blocking" request isn't unreasonable at all: We want to establish
clear criteria, by which we can then also go in the future. And we want
to make clear what, if any, baseline requirements are acceptable to put
up beyond consideration of just binutils and compilers (basic utilities,
make, perl, python, etc).
Jan
|
