Re: [XEN PATCH] xen/arm: fixed violations of MISRA C:2012 R8.3 on parameter names.

[Federico Serafini <federico.serafini@xxxxxxxxxxx>]

On 22/06/23 10:50, Michal Orzel wrote:
> > > diff --git a/xen/arch/arm/include/asm/vgic.h b/xen/arch/arm/include/asm/vgic.h
> > > index 328fd46d1b..aa9f49409e 100644
> > > --- a/xen/arch/arm/include/asm/vgic.h
> > > +++ b/xen/arch/arm/include/asm/vgic.h
> > > @@ -355,8 +355,8 @@ bool vgic_evtchn_irq_pending(struct vcpu *v);
> > >    int domain_vgic_register(struct domain *d, int *mmio_count);
> > >    int domain_vgic_init(struct domain *d, unsigned int nr_spis);
> > >    void domain_vgic_free(struct domain *d);
> > > -int vcpu_vgic_init(struct vcpu *vcpu);
> > > -int vcpu_vgic_free(struct vcpu *vcpu);
> > > +int vcpu_vgic_init(struct vcpu *v);
> > > +int vcpu_vgic_free(struct vcpu *v);
> I know that new VGIC (files under arch/arm/vgic/) is not covered by the MISRA 
> work, but
> functions there reuse the same prototypes. So by changing the parameter names 
> here, we
> should also change the names in the following definitions for consistency:
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/vgic/vgic-init.c;h=ea739d081e7879b44c4b05c862ad32c301105732;hb=HEAD#l201
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/vgic/vgic-init.c;h=ea739d081e7879b44c4b05c862ad32c301105732;hb=HEAD#l242
>
> I can do this by myself although it would be simpler to have all in one patch.
>
> ~Michal
Hello Michal,

I can do it.

Regards
--
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)