[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/9] xen/arm: Check Xen size when linking
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 26 Jun 2023 06:15:39 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jeo8+7oEOCBoHb+Ou1kIWqrZIsHIYMZD/l8MLXVWJ1Y=; b=Zz40m5K9Qc24FABUlSyMRIDiiZZS/sYJdB8RsIUo1LgidH7Nr7Brwkri7DcNJwmXHOUOG8a9brVlUndXaBQigLuZGCEmvPUxnIiJrbn8BDYFnIGijfJUvYonDjeblFSsamccZxpQDszdwXNWRYhwznxC9VRSB5nP3ogw7ONzHnB69p7r2JcYaFMs5vRjzNQSnKkJP3bdXYkL2JKMuw2XjWgbLkuw8vg3pdR4gme4FcARCn7/NmeJkyeq1Egcc1DGrXS1VGS4iWVaqPoHOQ12o1dOeyUdGo6iDsl7T4aKAnTyxxmVS8Lc8MPiYfdgufv+x02pusPstExxAjIEHd3IBQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j2bpVU+w3N73tg1dQYVHMydXKdZ1qX4ieIeJ7bT7mqHQEmFRFhbuRtGNkINkGhWWTh4/e0Jd/ciUeqGDx8vBkmKlIXVqv/haz412peslVYb5DdZYdLBa8ZikLr9gx6GaFMdRu+gL5GF+a8dTklx74SfXzLR707zUuVLYtmMBSvWB8CUbyp/crdtxun7/Y+bqQf5zgOkJLDd5r6kQg8gmr1/OoM2xiiNICtL+zWZXTAofrHYA+S+D9L6d7H6BeeOFylXGd4O+vS592JROD/75sXfbAMponna5pm3auwgBvSnWTqq3SH8xVvKd147PwCelOMCyqEk/KqHYiUpwvNgm6w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 26 Jun 2023 06:16:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZp6aLOomj+n7mMk6Gpm2cByrsNq+cmVMw
- Thread-topic: [PATCH 1/9] xen/arm: Check Xen size when linking
Hi Julien,
> -----Original Message-----
> Subject: [PATCH 1/9] xen/arm: Check Xen size when linking
>
> The linker will happily link Xen if it is bigger than what we can handle
> (e.g 2MB). This will result to unexpected failure after boot.
I found this a little bit misleading because when I looked for
XEN_VIRT_SIZE, I am having:
#define XEN_VIRT_SIZE _AT(vaddr_t, MB(8))
May I please suggest it is better to keep the example in commit message
consistent with the actual value used in code?
>
> This unexpected failure can be prevented by forbidding linking if Xen is
> bigger than the area we reversed.
I am not sure this is a typo: s/reversed/reserved/, but I find the current
sentence a little bit hard to understand.
>
> Signed-off-by: Julien Grall <julien@xxxxxxx>
Both comment above can be fixed on commit, so:
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
I've also tested this patch on top of today's staging by our internal CI,
and I don't see any build error there, hence also:
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
