Re: [PATCH 1/9] xen/arm: Check Xen size when linking

[Julien Grall <julien@xxxxxxx>]

On 26/06/2023 07:15, Henry Wang wrote:
> Hi Julien,
Hi Henry,


> > -----Original Message-----
> > Subject: [PATCH 1/9] xen/arm: Check Xen size when linking
> >
> > The linker will happily link Xen if it is bigger than what we can handle
> > (e.g 2MB). This will result to unexpected failure after boot.
> I found this a little bit misleading because when I looked for
> XEN_VIRT_SIZE, I am having:
>
> #define XEN_VIRT_SIZE           _AT(vaddr_t, MB(8))
I think you looked at the tree with my series applied because patch #9 
will bump the reserved size. The value in the commit message match the 
current value in staging.
[...]

> > This unexpected failure can be prevented by forbidding linking if Xen is
> > bigger than the area we reversed.
> I am not sure this is a typo: s/reversed/reserved/, but I find the current
> sentence a little bit hard to understand.
It is a typo. I will fix it.

> > Signed-off-by: Julien Grall <julien@xxxxxxx>
> Both comment above can be fixed on commit, so:
>
> Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> I've also tested this patch on top of today's staging by our internal CI,
> and I don't see any build error there, hence also:
>
> Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Thanks!

Cheers,

--
Julien Grall