[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 21/52] xen: introduce CONFIG_HAS_PAGING_MEMPOOL
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 26 Jun 2023 09:01:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ziQBtY/vCXPacWsma6Ji4xwTPOkjPa6xuf7cYjualXM=; b=Xxfp7+z9J+pNKYRXLX4r+q8awkgxiZ6D1goPnIS3uSCHRtvOVW7gZms0UpAYbDe5pst74GA/gOrWQ4nE10KNoEhO6NOhJIJ0GjQnq5Ht5CtOdhr1cNNcIZGEl3Y/TlDA3ubvZbNQZkbRf6hUa+0NnLxWpk308VDy6VCvouIRcWI7AXa7V1AWSO2NpnTrE4xiHCKRXunLRQ3VSR05XojPe/x1U8pw0uEpeV/dxBt8UjZvBZdu1PZC7VkCEaYEhw508F3seRaCqO3v6uqvdTr5Z93/O0gaiVcALThuUXWpcPJkG5sl+xXE20VZUskxvyPlSm1DH8XN+fcl5GhEttcELA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hkTxt/okZInFj2gMhp2TxH/+34gNc44O6Xkv96EYbn+UcChgqlTaJzww5jY7hacHJCmdRZFcNpy/FE+ARRt1Ze+OLq7nOKNiEE+BqMBSUxXtZKUSRT6ZoOAyK9hTpb/ibekMdT2wjbmO40KK6uKFnJCiUy4guzDVQjKh/1iC2fMGwh3ycq2hsmgzmZEULbzfLC4v8Iq8u4mR1vle0fkcBmB8FWxl8SErzIZAJ9MxUGzIoTtp+8zTWYrIw4ISJJJq/Ghk3rNZ+mp5VQgZAL86IXkxil+ncrB3yQLns2ocYj+nXg7LQTrHjO0rYP+EyOCqbDdEb9r9R5NJo7PGe9bOfg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 26 Jun 2023 07:01:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.06.2023 05:34, Penny Zheng wrote:
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -54,6 +54,9 @@ config HAS_IOPORTS
> config HAS_KEXEC
> bool
>
> +config HAS_PAGING_MEMPOOL
> + bool
> +
> config HAS_PDX
> bool
>
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -844,6 +844,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)
> u_domctl)
> ret = iommu_do_domctl(op, d, u_domctl);
> break;
>
> +#ifdef CONFIG_HAS_PAGING_MEMPOOL
> case XEN_DOMCTL_get_paging_mempool_size:
> ret = arch_get_paging_mempool_size(d, &op->u.paging_mempool.size);
> if ( !ret )
> @@ -857,6 +858,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)
> u_domctl)
> ret = hypercall_create_continuation(
> __HYPERVISOR_domctl, "h", u_domctl);
> break;
> +#endif
While I'm not outright opposed to doing it this way, I wonder
whether it wouldn't be better to leave common code untouched by
making arch_get_paging_mempool_size() do what you want done.
That's part of what arch hooks are for, after all.
Jan
|
