[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 1/3] xen/arch/arm: fix violations of MISRA C:2012 Rule 3.1
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 29 Jun 2023 14:41:34 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lBaIWQRoF1ceVdV/20efyPwXqZt64SKR4raOmqcPsM0=; b=OFFtTAT16E4aWYEW3h9XpbXCAOsN8Yd28+ZfPCHeHiWnq8ppSPrRMASmfs4cr7b5SCzaILTSPEBK4ZixayoxniHAzSt0BsSloo2MIvKlyVX3Hq080tASdbXy4sojYr0WvCStobyvmeZVjLbdTj5Lc81EJ2O9QH/f1q6I8Sj5uulXjyJB6480Vv4UwOvbfU2mDw3JFswr3emfBclCJ5qm5FOSeuGT8DPivaVZBC4oaQArf8RMtXMZgduWPV7MbT4TlCYNxpXKzZfp75P21O89pJ+GXZ2tOAJhJX/I6pW7/LjO16cR3xJ3q9yIJSXf83yp5U/b2FQDxehq+5zbj/HOaA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LX6BjXNBx5BhzNJ2YSBR1upA8Tcn+R5s+ezPv9eI9UBDyT4iPz2NS700PHEGnWXvGqreR8t4t2d2XjV4JDiSnbLf8PFt8tB5/InTTFl8hCi6p0BPWf3YX1W9C4zlm5BiQfuaolS5vjAeT44MRtVljf5wLmtN2A8n6fC6qlZI+Z1fId4vcMkQE0pxrWoroxHfS38mAkYWbHvLfuWa7Sdoq/dmUtAtkXVxZSxtYBcdQAprcJbTKQRj52ZTX2lB6FtNRwDCz7CblHDweHKfM+9jO6lb55hoaQggbWoqMiiO82KZc2covKOzuNLMKoilKMTPHyCPZg9tx5G39EygF9+RAQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, "ayan.kumar.halder@xxxxxxx" <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 29 Jun 2023 14:42:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZqnGGC/1ABJScNUiVVSDKy4Xa0K+h2qmA
- Thread-topic: [XEN PATCH v3 1/3] xen/arch/arm: fix violations of MISRA C:2012 Rule 3.1
> On 29 Jun 2023, at 11:06, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>
> In the files `xen/arch/arm/include/asm/arm(32|64)/flushtlb.h' there are a
> few occurrences of nested '//' character sequences inside C-style comment
> blocks, which violate Rule 3.1. The patch aims to resolve those by changing
> the inner comments to arm asm comments, delimited by ';' instead.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Can I suggest another commit title:
“xen/arm: tlbflush: fix violations of MISRA C:2012 Rule 3.1"
Sometimes when I am not sure on how to deal with prefixes, I check to the git
history of the line I am changing, for these lines there was a commit from
Julien using these prefixes. I’m using vs code with GitLens extension, that
ease a lot this kind of checks.
Apart from that, the changes looks good to me:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
