[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH v3 1/3] xen/arch/arm: fix violations of MISRA C:2012 Rule 3.1
On Thu, 29 Jun 2023, Luca Fancellu wrote: > > On 29 Jun 2023, at 11:06, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote: > > > > In the files `xen/arch/arm/include/asm/arm(32|64)/flushtlb.h' there are a > > few occurrences of nested '//' character sequences inside C-style comment > > blocks, which violate Rule 3.1. The patch aims to resolve those by changing > > the inner comments to arm asm comments, delimited by ';' instead. > > > > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> > > Can I suggest another commit title: > “xen/arm: tlbflush: fix violations of MISRA C:2012 Rule 3.1" > > Sometimes when I am not sure on how to deal with prefixes, I check to the git > history of the line I am changing, for these lines there was a commit from > Julien using these prefixes. I’m using vs code with GitLens extension, that > ease a lot this kind of checks. > > Apart from that, the changes looks good to me: > > Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx> With Luca's suggestion (can be done on commit): Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |