Re: [PATCH 8/9] xen/arm: Allow the user to build Xen with USBAN

[Julien Grall <julien@xxxxxxx>]

On 29/06/2023 02:36, Henry Wang wrote:
> Hi Julien,
Hi Henry,

> > -----Original Message-----
> > Subject: Re: [PATCH 8/9] xen/arm: Allow the user to build Xen with USBAN
> >
> > On 26/06/2023 08:29, Henry Wang wrote:
> > > Hi Julien,
> > Hi Henry,
> >
> > > Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
> > Thanks, I will fix both typos.
> Great, thanks!
>
> > > Just want to make sure you also noticed this, otherwise maybe you
> > > can include another patch in the series to fix this?
> > I haven't seen this one. Probably because you would need a setup where
> > interrupts are around ID 1022.
> I took a closer look today, I think the reason is from this device tree node
> for the FVP:
>
> ethernet@202000000 {
>      compatible = "smsc,lan91c111";
>      reg = <0x2 0x2000000 0x10000>;
>      interrupts = <0xf>;
> };
>
> The value 0xf is  passed to vgic_get_virq_type() as "index" then "intr" in
> VGIC_ICFG_MASK. Hence the 31 in
> "(XEN) left shift of 1 by 31 places cannot be represented in type 'int'".
>
> > Or I can do that
> > > in case you don't have enough bandwidth.
> > You have the setup to exercise the problem. So it would be best if you
> > do it.
> I've prepared below on top of your series:
> -#define VGIC_ICFG_MASK(intr) (1 << ((2 * ((intr) % 16)) + 1))
> +#define VGIC_ICFG_MASK(intr) (1U << ((2 * ((intr) % 16)) + 1))
This LGTM. Feel free to send a patch.

Cheers,

--
Julien Grall