[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] cmdline: parse multiple instances of the vga option
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 4 Jul 2023 15:30:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EZxWrJPo11d4CXK2s+cv8367KL6szoxU2f/YBDm96Yc=; b=TWy7k+oBykGIOmOPmrFlpviO1Z/RZhIzAKMBO1RkZKIAi9hJR79FC21o97OHs+9SGm56Ka20foJPdI25bsVIhXVPuWwhBA+H4ftiquDeADCU+qhMtvQMm2EY7Ehnvr8okaXE2VWo8NWrn1ixo/+dWUju6n3TgJYOHm6ijNN5LPrcLl65JrtdFMxNlTKgIFn3YawXKQTtt2PyoLT6viwWz5TdMGMEo8JNKHRFR993KoAKgpvubft2cvjzt0Wts1IFoXsIXTlU0fKdxircaIMGozBhNNCQcArs4rsi/1jB353JugmMxTRUi4BELIIWppN8imiARi4rfCDuaD1sZcqEgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5feD0iZ0EwZsz89Vx2tXQ47rGmSgceff73kmk3VxgBToI6+1j2q/oMB7a/bZ5WFAw7hkxOQC33jbf1Rz9IqBoSovEW6fJ4JjG5NC2rA4VyQzJSpVFzYNGyhXc6dWrT6QBcZUxUbwG3229Sz3LQAULUFnXU+f+7CeONUOPyi1FEv4uwW/S6JjTGK9oiZ5/fxD8stagQ1WFELMcRChvLbZClElXUsiSM6KU0XXy6izBkom3ctZ1suz2aQqDqbL6ffTQf9wXBepVwKmbGM132T25Kje9r+RMxUGnJ5YbmgWsclDCCCVJA37r0DtNAuAUmpoC9h97NI0SU7DPHl7Drfcw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 04 Jul 2023 13:31:11 +0000
- Ironport-data: A9a23:m6WjQKtJ/VtJsj1vUp0GeEqQ9efnVJhfMUV32f8akzHdYApBsoF/q tZmKW7VOffeZWX3eognOY6wo0gB65PTn9M2SlZprig3Enwa+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5ACGyyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwAgsqQjSe1r2N5Z2EG9h9pdY+LMDkI9ZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4e9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAdlCT+Tmrq8CbFu7wlITFR5KbEaAkeSD1US6fc1ZK xYm9X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L84RudB2UCZi5MbpohrsBebScxy laDktftBDpumL6YU3SQ8vGTtzzaETcRBX8PY2kDVwRty8nupsQ/gwzCSv5nEbWplZvlFDfo2 TeIoSMiwbIJgqY2O76T+FnGh3enocHPRwtsvwHPBDv6s0V+eZKvYJGu5R7D9/FcIY2FT16H+ n8Zh8yZ6+NIBpaI/MCQfNgw8HiSz67tGFXhbZRHRvHNKxzFF6afQL1t
- Ironport-hdrordr: A9a23:YjBl2Kt0e3H/UgdydKJSDhnu7skDhtV00zEX/kB9WHVpm6yj+v xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBO3ZogEIcxeUygc379 YDT0ERMr3N5CNB/KHHCAnTKadd/DGEmprY+ts3GR1WPH9Xg6IL1XYJNu6CeHcGIjWvnfACZe ChDswsnUvYRV0nKv6VK1MiROb5q9jChPvdEGM7705O0nj3sduwgoSKaCSl4g==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jun 07, 2023 at 12:07:54PM +0200, Jan Beulich wrote:
> On 01.06.2023 15:05, Roger Pau Monne wrote:
> > --- a/docs/misc/xen-command-line.pandoc
> > +++ b/docs/misc/xen-command-line.pandoc
> > @@ -2628,6 +2628,9 @@ with the specified width, height and depth.
> > `ask` option. (N.B menu modes are displayed in hex, so `<mode>`
> > should be a hexadecimal number)
> >
> > +Note that all the occurrences of the vga option in the command line are
> > parsed,
> > +and hence later occurrences can overwrite selections done by prior ones.
>
> I'm not a native speaker, but is it perhaps more "override" that you
> mean?
TBH I always get confused with overwrite vs override. I will remove
the line as requested by Andrew.
> > --- a/xen/arch/x86/boot/cmdline.c
> > +++ b/xen/arch/x86/boot/cmdline.c
> > @@ -277,59 +277,58 @@ static u16 rows2vmode(unsigned int rows)
> >
> > static void vga_parse(const char *cmdline, early_boot_opts_t *ebo)
> > {
> > - const char *c;
> > - unsigned int tmp, vesa_depth, vesa_height, vesa_width;
> > -
> > - c = find_opt(cmdline, "vga=", true);
> > -
> > - if ( !c )
> > - return;
> > + const char *c = cmdline;
> >
> > - ebo->boot_vid_mode = ASK_VGA;
>
> I think this needs to stay here along with the addition of the related
> "else if" below. Otherwise I expect behavior for e.g. a sole "vga=keep"
> on the command line would change (in no longer prompting for the mode
> to use).
Done.
Thanks, Roger.
|
