[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: XenSummit: Empty per-arch files
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Jul 2023 15:39:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=134+lnW6M8o5uUgaYmeEKgQrOjOjiI5sdQXc8ZqDUTs=; b=KlXho/ymW1jkwDC1ltH7pF0H0rtCM8IHjsq/IQ2+isGcbRsit3ZwLFAhDBFtckmZJuebQIVY4Wo0ABMB+vECN80UbzG3D7JJ+5J0xU4wFCNWqkCyaExoS183q8m8/j2sp9Yc5DPHKLJwyLB41aUhoW7pXxHc3rmB8S9uSH2KJCdR4C6dz6x4me+kkFETECcpgvyvhTugk5N4OYnD9svylrj8+/ytJbSqebL4vgVA0UiWsZvFf9RsSZoA9NQQ5piTzsHBXd/8v5YHksexZ66ATZbIG5ir00ISotWOEWreb4i540tB5YT33kBm+TxAEsqmr0Hau8EQOUdOpFhw6pBEyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l61Y8kkue908wus6N9YdSUQoJ4bADhLt4ftLCHbb9OWwi1mQFjyNj4YqbOJZr2zWutmNp43J3GiWq0NqjMefmX+MeX59wSfxtIOajI9kk9fnNK1k5GeaalqAQVoB6d87R9qoAPsaNovs9W5schgkH/lxn2sqPvrc6OEaEDu8prMO1I8AgaS01aE67upmYiIPb1KihOPXyeRmQhqppT1fpdq0yk/yZ2xHXIuJxVRaIPC4b94+hY63hegWzyv8v6gO8xnvJYgAbcgrmX9llrLhqjuHQSiL61mHQk0iY6V+0k2wxRHXHTNMQLevFVJ0JnAYDPzhrQ75SXZre7moxdgzyg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bobby Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 04 Jul 2023 13:39:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.06.2023 13:32, Andrew Cooper wrote:
> Hello,
>
> This wasn't a formal discussion point at XenSummit, but Oleksii pointed
> out that it was still a problem, hence this thread.
>
> As we take on more architectures, it becomes more and more important for
> things to be handled in a mostly-common way. With that comes quite a
> lot of <xen/foo.h> including <asm/foo.h>, and the arch one being a stub
> in simple cases.
>
> It would be nice to get rid of the stub files; they're irritating to
> deal with, both when refactoring and simply for the file bloat they create.
>
> There are two options which come to mind.
>
> 1) Use __has_include(). This would be ideal, but would require us
> bumping the minimum GCC version to 4.9.2 as a prerequisite. I'm not
> aware of any way to emulate the necessary behaviour on older toolchains.
>
> 2) Have a stub "architecture" which is always last on the include path.
> This would reduce the number of stub files from one set per arch, to
> only one set.
I'd be in favor of 2, which iirc is also how Linux does it (in certain
cases, iirc; or maybe things have changed yet again there). They call
it asm-generic/, which I think is slightly better than anything with
"stub" in its name.
Jan
|
