[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 4/5] x86/x86_emulate: change parameter name from 's' to 'state'
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Jul 2023 15:57:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MMuiqdglR/yPIudSk30KF3EwEAcpwXt/Lg63G9vNeGc=; b=e4PwJwn2JqQlUthLSaceqKYkEyPViknhEYLSz3TPlED9vqmFoAbKkTdgrZkqldgSEt7Ujl6NpE6TwUAp5M+gK3/UHyiTUpsYiPTt+5fxHXQ6MjAQHur17UDEXda0NwyYH6I3X6muVr7JWX6avSpw6vV6jgkDyBvtpAvaIVs5TgNGPHPpzbtA9E8MqFLE1DoEJVLVHNyxU8PtQj1j1ojt9M6BVE8P6kUFSaJYIPVi9Z/uV8vergM+ESTvbfjo6Mw8ZGVys0t6+xIHUmll2uvBAtMnRb7fhYZM2J8mJAUbIudbYZAtJyLopZZwMvOzY6lcURbx5Y5W6Ml1ZCU/qDMCSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SlYME6nsKhCsEUXXuLCgfFkqTUJkVDcYuYqyZEPp+uY6acogP1iMPN88ER5CLvCEE508rhU3V8CU2SBoaEQErDzqXDWCbQWH9ZbQbI+whlJB8NZe0tTZD9bJs3EJlC1E1pnqiL06ONr4lTqdTYdHwCdy5xYUUa/E7Q30zj66XygyjD7wABPraZI1FhXtxJjpoaarDl+vFgSfOXY7XTi1qHe1grwtbUf0qSkMyoz7THMNxGPR8mK19u2INntrI5NtzSyUx4DVG3Xtb8jC8nWSGBYGShz6NfWIEtzf/yx6+3/gO3/0PEdNzOJfuJ+hHj1Ylu6H/7t3O83GhhTpBhk/8A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- Delivery-date: Tue, 04 Jul 2023 13:57:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.06.2023 21:31, Stefano Stabellini wrote:
> On Thu, 29 Jun 2023, Federico Serafini wrote:
>> Change parameter name from 's' to 'state' in function definitions in
>> order to:
>> 1) keep consistency with the parameter names used in the corresponding
>> declarations;
>> 2) keep consistency with parameter names used within x86_emulate.h;
>> 3) fix violations of MISRA C:2012 Rule 8.3.
>>
>> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
>
> You could use x86emul: as tag in the title. I'll let Jan choose the tag
> he prefers.
x86emul: or x86/emul: is what we commonly use. That said, I don't like
this change. The files touched are pretty new, and it was deliberate
that I used s, not state, for the names. This is shorthand much like
(globally) we use v (instead of vcpu) and d (instead of domain).
Jan
|
