[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 5/5] x86: make parameter names of function declarations consistent
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Jul 2023 16:00:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gll7WaYdb8WKnaoDfTPkTUK3k2BeCemleAxdO6F4qNo=; b=Z67RlhSK8qtURFLls64BTlKpIefvZjrU16mo5coMSg6O5Px6hVx1Mj0e8W3CB3jIZCmUmu3Qx5oBwMGUprwL4CkEo5hP47o4egLK49Cz3aGLKX98YkaYBy+/mBAqHABtuTI8FJoIG5uUB4cdhpN4ljBQMHUXoWxYVm8bErxRSwdDel3q8/l7Xte8WNxFMOicTmaSZqqaJKOczBoYGgolX+F0zhSt5wPFbTG3jbbQQaCvm3TWAeD6L8w4HE4p7qaiiwCjWTnaozYetCw/pmsR5XoQubQ2shNHF25h/nwjwNwGnaDQK4szcX+9z29VyY2XjUqjPEippPBMHP17JXdXEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kZlPC3vMUIxxH/RE7HuKeAiAVKN33yHhf5QhD62F0YR6GSkaHf+ffVIWzOTAEPMNHEbT9BrdHqMExUaWaPviYOGhNa9KnPBlAu/XlZ2GzJBIQONEnOfKUHgT5B2n1sk6/qJ3/iOv0kkS1hYn5uYgsti/ScKkXNr/zNrYqPHWQvue9El53vGlGozghNBBOYYydBoyeB8SXpJeXjUXh24pPDHiAFfrXcPHYfexNYZzYR6t9MWI2espUJaa4iGq1JveaHovMRdh3mf9Ut35hT3dVcnFNKSXY8K18HtmGbvnuKHbcVccL8ac06EEmbQp2Tg4poa962Wc3h7Bf1vj1+dO+w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 04 Jul 2023 14:01:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.06.2023 17:55, Federico Serafini wrote:
> --- a/xen/arch/x86/cpu/mcheck/mce.h
> +++ b/xen/arch/x86/cpu/mcheck/mce.h
> @@ -44,7 +44,7 @@ extern uint8_t cmci_apic_vector;
> extern bool lmce_support;
>
> /* Init functions */
> -enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *c);
> +enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *ci);
Supported even by ...
> enum mcheck_type intel_mcheck_init(struct cpuinfo_x86 *c, bool bsp);
... immediate context, c is the name we use for parameters of this type.
You want to change the definition in such cases instead of the
declaration.
I also think this patch could do with splitting, not the least to
reduce the Cc list(s) needed.
Jan
|
