[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/asm: Introduce a tailcall pseduo-op
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Jul 2023 16:29:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qUo9VbqK1E0QofwcLeUuuaBC3c3sbvfQKGI0IvuYq8o=; b=Ipo7NSUySHIhs5FK0Av7vGAppBDsHSclIq8VSlEhf55YvC3TBiB7rAuYvFHcN5MKyCoITXUeo01nGro1IXeTa4RYeDa99ejaMZbsy+Ecv6WHxChOaBGF/FWyif3E3jg8IW5WuI/V7SeJohCJJk/PSskalZUHBQI6i6gg84it+s0IqkicFuzkQ/4VwLIy9O3di+sJ1QlEkpuPdNtR2BksdSEMFJWizrFFUCbh4+ttkrP/Pj5BMO68DNoiUpGIaNVCQi01ducFnh2VKQsWuMUSS8kGldLhAIwCUqZqjdu/M/f0TiNMQ0S/HRolJxVt+kDTmuwEs2BAMDWLs07SuxRurQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLORJO8KQhFzUMU6iyoUEt+duBdecNw6+ExxS1fylfUnoBqQB2ldQ3CD6PnEApRbuDUwT5rnlGsh2cBN7ujLivgaSksh9a4bWVVUkQGIU514n1F9bkMVC9EoWFVQdRCUYVbWtl8Ox3OX5LAdr1YlXlX9l+sanKlHFJPaIX64ku1qyBEDBTBjCO49zFl/Gw/jLhHq9+5AiX5AcZpdVXZdSXAeqW0vPZnvVZ/l7DcvAdDCL/4pltlCMEhEScLfuiRXwDOHyKf2Lulk1QxV7y/SkKyANEkpLnhh083R6GWY+gmmPfuEpGbBYLpFEQVYx5F1HKsKP3jK91Fiklsw6VQpgA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 04 Jul 2023 14:30:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.06.2023 17:20, Andrew Cooper wrote:
> It was previously noted that CALL/BUG is a weird combination, but there is
> good reason to use this pattern.
>
> Introduce an explicit tailcall macro make it clearer in context.
>
> No functional change.
>
> Reported-by: Jan Beulich <JBeulich@xxxxxxxx>
Did I? Must have been a long time back, as I don't think I remember us
talking about this.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
>
> It would be nicer if tailcall was shorter, but that loses clarity. RISC-V has
> 'tail' as an alias for 'b', but that looses the call aspect, and tcall isn't
> sufficiently recognisable as tailcall IMO.
I agree with all aspects you mention here.
Jan
|
