[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/asm: Introduce a tailcall pseduo-op


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 4 Jul 2023 18:04:51 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WziFgsL/Izmx8nMR387oIXKDLqcCWewMvvWHh1fJaKU=; b=Lz0AU5xqpql8iMoa3iTDrBVfqMBpy3uuePbnNvFrbrRCvpxzDMBV56OhpXPZj0t6WBHrISkeBfbPVpz10G1XXp7mEnd3Wv/4xK2QrygR3TMyXNRX+JNls7J7zKletD6MVxDLjG0/4ptqpoYDOkIxl+aeMosIF+fRxbQA6iGEOj/tucdfQelQeBfha5wlCK1zJLBn24ubXYjzqYNWvFjwcuI5btj0IBFBr2NVokS5VMx2R7x+h/gFdmcJTkV2wVQUe86BFkvSokpqbt4iohBrSKEjFF5LLPtrd1+2Kd/2HU0Za3XMEaoPl6TUIoO/k067WjzGJD/p+fc0Ty/yEkqqlA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DxLDtPkxIHrtFHj674Cc2CDFiM9miPicsBbwI4Mw4mFWGCJBGhn6lAhNk+dsveFw974sUGWt/sLWlr15DBlXh9gOyHhR5PHdAe/6ycuga68jrbePB8LYoA+hpuUOD9BrICHLK1OHP6+otZe3d0gZO32JwzDOUBzqWniBE+g2JyGoxTHBuzc6ICiiU0d5BJq7b7hWRShrhYrJYfk2laso4FE5VkgpmVQJ3K69UBo9wZHENryUTl4Y7qSCNL2xW6NE12QgbTempKJbKeviqwleS0gcDGVLp/k4nUdi2bO340c5nGgMbxx6/RoXU0rb77KetRjNdU2QGhBLEduD6qgrNw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 04 Jul 2023 17:05:37 +0000
  • Ironport-data: A9a23:54T6VavKuw+ddK/icS6Fyp1YqOfnVHtfMUV32f8akzHdYApBsoF/q tZmKT+AO/6JYjb3ed9yb9u29U1SscSEztdlGlFu/ypgFStA+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5ACGyyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwEj0WZC+io/2K0ejrae53r94JB8LLM9ZK0p1g5Wmx4fcOZ7nmGv2Pz/kHmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ouiP60aIa9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOThqqI22wXMnwT/DjUrZ12anteFp3KeWsxfK 1NPoS0Lh44boRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey9zqoYV2hBSQSN9mSfaxloesQW22x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBN/xooWp1 JTcp/Wj0Q==
  • Ironport-hdrordr: A9a23:cA4kEqFAPfzrHiK9pLqE18eALOsnbusQ8zAXPo5KOGVom62j5r iTdZEgvyMc5wxhPU3I9erwWpVoBEmslqKdgrNxAV7BZniDhILAFugLhrcKgQeBJ8SUzJ876U 4PSdkZNDQyNzRHZATBjTVQ3+xO/DBPys6Vuds=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04/07/2023 3:29 pm, Jan Beulich wrote:
> On 30.06.2023 17:20, Andrew Cooper wrote:
>> It was previously noted that CALL/BUG is a weird combination, but there is
>> good reason to use this pattern.
>>
>> Introduce an explicit tailcall macro make it clearer in context.
>>
>> No functional change.
>>
>> Reported-by: Jan Beulich <JBeulich@xxxxxxxx>
> Did I? Must have been a long time back, as I don't think I remember us
> talking about this.

This was discussed on multiple patch reviews, where I was introducing
the pattern and you were complaining about the BUG and comment.  I can
drop the tag if you'd prefer.

>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.