[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Backport request (was: [PATCH v2] tools: convert bitfields to unsigned type)
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 4 Jul 2023 17:55:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5YXhD+nWazyqIPf9QUc22wSfzJIADbl523pHct1rSbI=; b=YfpE7BDgLR1RJcQvN3pzuEx4PqWzH0wZY3xVLPnUX9ufHeLEzsGRY0JgY1Q5LODIrgmkgIN9iSRvMpNVUgHBt54yL3MRohU2nhjE2wMH4goeNNNirSiqKO2IzrZOzud6dy1R6HgSx5Cmmjux/bPYizJyHIQBRix6oWqrFOqcEU5avM1F10IRX7OIQgKjom8DfEJoPP98vqKkM4kvAyq0XElkVdrY5upWuz8m3P9yUQPHur1bjHmVUYzvhSNApSh6SIHf+C2N7u8RGXYxKnXEkUJiamD2MnAX4u9kswz+d0qS/6CfdksrVfX5O8HtIsqgeqyXdPq7qEu5nlikrMb8rw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JpAZq16RbVrdp8UY3a7h5firUB3C4VrruZYunZDVXwKvQaF79h/1rdNPiRRyW4vSnt1P/fKcgZ8d+HfxFmrbn8QjTY0nvK48iRTDe6sMofUEDY8OELLUPmEJRjkgw0ARNznmN6TSaBOQhknJPGyoqA5L0vYk8rh0+4cFApFPWbXk1dOYl6x09Smkat9idS1BbKtX6NKdTMuxjV5t1C9+40B9vNQq9Te3hX+CinxfkxU/Ul1aW8Nf1GpeJG/ollAvKhIIvENEKneOWS4o9OfzM1+pUYX+alKW2lbofHja5GmONLHBIj3cCb073s3ZET19jyaP4Wfa1VW/Hkmp2AYM+w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 04 Jul 2023 15:56:14 +0000
- Ironport-data: A9a23:7GkDDKmF/ATInQknzuW2Ko/o5gy3J0RdPkR7XQ2eYbSJt1+Wr1Gzt xJKCj2Baf/YYTSmf9pzO9+x8xsGuJDcztUxGwE+ryg3QSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5AOGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cAZFxscURexvej1zb64RdRcpJwHceC+aevzulk4pd3YJdAPZMiZBo/svJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVU3jOiF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxH6mBNJMT+TQGvhC0FS4lkECEwIqcVKdo76AkE6zYIl+J BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9UQAXInUFfjQsVhYe7p/op4Rbs/7UZtNqEarwhNusHzj1m 2qOtHJm2+VVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5T2ADwmZX1VqBGwfQ==
- Ironport-hdrordr: A9a23:hyUpT699CFfR81n5qmFuk+DiI+orL9Y04lQ7vn2ZKCYlEfBw8v rEoB1173PJYVoqN03I+urhBEDjex3hHPdOiOF6UItKNzOGhILHFvAE0aLShxHmBi3i5qp8+M 5bAs5D4QTLfD1HZBDBkW2F+n0bsbu6zJw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jul 04, 2023 at 05:42:33PM +0200, Jan Beulich wrote:
> On 28.06.2023 11:46, Roger Pau Monné wrote:
> > On Mon, May 08, 2023 at 04:46:18PM +0000, Olaf Hering wrote:
> >> clang complains about the signed type:
> >>
> >> implicit truncation from 'int' to a one-bit wide bit-field changes value
> >> from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
> >>
> >> The potential ABI change in libxenvchan is covered by the Xen version
> >> based SONAME.
> >>
> >> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> >
> > Can we have this one backported to 4.17 at least?
>
> Hmm, while perhaps simple enough, in principle this wouldn't be a backporting
> candidate. May I ask why you consider this relevant?
I have to take this fix in order to build 4.17 with current FreeBSD
clang. I think in the past we have backported changes in order to
build with newer gcc versions.
> Plus is the mentioned
> "potential ABI change" safe to take on a stable branch? There's not going to
> be any SONAME change ...
Is there any ABI change in practice? Both fields will still have a 1bit
size.
Thanks, Roger.
|
