[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 2/3] xen/drivers/passthrough/arm/smmu-v3.c: fix violations of MISRA C:2012 Rule 3.1
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Jul 2023 17:51:11 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mT6Xy78g6mlD36cWlfcq31hHskTqrQQajOhob0Lw9pM=; b=T4BHFjzOz+vFXImHH6BllNNcS1UInUgl09bkxKf6vAauIxYTr3nj8YY1dShECjp4TeOIgLt+E++FlPQY7Zq4CW9BnaUOkIcSlFoiLaRSdh5yqtnPi8hyOaf4Vum6O5t2FjHmaB2oUvClWeRCe+F1IySqooU6kl0lGDVY/MON+dDO+b3DOwirLzbvZOjjPZHsi9hRrskZs8AHdq53K9jU93XD6vhHovyvdG2UwRW1tCUtOokUvo1BqLURzya7+axcS7LNL+h1ib50UlTNTjOusgbVUxofjQMGUBsjiW3Zj8newy3Gip5QDTjuO9Bt1ajZfrA2yAIKlPqgG7wNLhLSyQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZnR9Qjt05YkLNDrruO+vIe6SoBdh+pEyEqYDe8lw3Dzo/hWXZNO2n3co0vR6VlpjjVqPCl4SYfcDeelhvi4N2K6q0Cvie0HCb0hbso/kAbVMe4rbhZa9Fs6lMw/q0wD56C07yKDeYk089H0kygGYluxPJmUCquoFEWmsRXXAuBazy++0eKIzlNx0XtLxrzkHP5m5+wD0F6vckGj0R7HjGfi+PBR4qQPV442Gz0iSiF+jU/xWcnTZCbjTM5jvM1fw65z8Tq6q5CDlgsmd8vyyHyvKloBnBmv2gzghD11s20S8VWGJJNoX7onos47cT96qETHhYotY+w0w+xUywysIUA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, "ayan.kumar.halder@xxxxxxx" <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Delivery-date: Tue, 04 Jul 2023 15:51:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.06.2023 16:52, Luca Fancellu wrote:
>
>
>> On 29 Jun 2023, at 11:06, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>>
>> In the file `xen/drivers/passthrough/arm/smmu-v3.c' there are a few
>> occurrences
>
> here you use a different character to enclose the file path (` vs ‘) may I
> suggest to
> use only (‘)?
>
>> of nested '//' character sequences inside C-style comment blocks, which
>> violate
>> Rule 3.1.
>>
>> The patch aims to resolve those by replacing the nested comments with
>> equivalent constructs that do not violate the rule.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>
> You are missing the “---“ here, meaning that the lines below are part of the
> commit message and I’m sure you don’t want that.
>
> Also here, may I suggest to use this commit title instead?
> “xen/arm: smmuv3: Fix violations of MISRA C:2012 Rule 3.1”
Just to mention it: Personally I'm averse to such double subject prefixes.
Why would (here) "xen/smmuv3: " not be sufficient (and entirely unambiguous)?
Jan
|
