[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 2/3] xen/drivers/passthrough/arm/smmu-v3.c: fix violations of MISRA C:2012 Rule 3.1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 5 Jul 2023 08:40:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=47wYujmxUbwb3Q4zhgp3DtFcdHgmy7H65HQAdh2HAng=; b=TbAbx5A67tr82HvZzQdrw37Pt767EBi25afUXJAwqWSjD2sFhZVADgHcP55jnW4v3/58YFFq/ymHA1OIf9BHPYzhJ6k7z8AJ0rgGS572jTtePiP1MdLEFUoqUPfe5gvpyAGGS+X/54z2ZnCCeG94PwHQFYjNfS+iR8mOan/Ld2/NtNjXkzeQ1HnMVnBfEym/dDgTS2XTMnOvFIbOyDkCPViFTwS82q2xBKcUkYO5JRLTW2+8YxVo2elknGmOAOnt/c838qpxcMWDDDNwrTQNZ37NQlv0pae/PtJNPrLjKURA+pSSoeF+yAcGklBytfNlzZdK7cUCUnnYOErUqLWotQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UPMIYLAGmrb5/4Y5REZjnSJTbGhJjLeDPavSkGvaCKDDrhZaiFB32EC/4C5C83msv/wH0yegggQ5nphXFYBUrYRY7bbLGhI9pHZkMwjwYdyc2OOzXxdDrnObe8q1SFM8YMxTvfH+/aeDXSKvnP/7UpNZP7sMgOZRDedvGQR4lDCBYPt5H1rvVBAf9dqa3qv1QUSrsUcNfACDQj5OYM6PHCQ4Dspkia8CKdNzktEolUCj4e7NpO00t9LTYltsZ9q5R9fnSkmh/fInBVGTRuHa6XZK3EvwIMzra8VHNiSj+o8qQIQb7bgWP9wnofWMRpuvZdkW5IEYVLfCFd1LH8cWxw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "xenia.ragiadakou@xxxxxxx" <xenia.ragiadakou@xxxxxxx>, "ayan.kumar.halder@xxxxxxx" <ayan.kumar.halder@xxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Delivery-date: Wed, 05 Jul 2023 08:41:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZqnF+MEQOQBJ9JkqCgXsEWfzVu6+h3a0AgAfsJYCAARnyAA==
- Thread-topic: [XEN PATCH v3 2/3] xen/drivers/passthrough/arm/smmu-v3.c: fix violations of MISRA C:2012 Rule 3.1
Hi,
> On 4 Jul 2023, at 4:51 pm, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 29.06.2023 16:52, Luca Fancellu wrote:
>>
>>
>>> On 29 Jun 2023, at 11:06, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> wrote:
>>>
>>> In the file `xen/drivers/passthrough/arm/smmu-v3.c' there are a few
>>> occurrences
>>
>> here you use a different character to enclose the file path (` vs ‘) may I
>> suggest to
>> use only (‘)?
>>
>>> of nested '//' character sequences inside C-style comment blocks, which
>>> violate
>>> Rule 3.1.
>>>
>>> The patch aims to resolve those by replacing the nested comments with
>>> equivalent constructs that do not violate the rule.
>>>
>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>>
>> You are missing the “---“ here, meaning that the lines below are part of the
>> commit message and I’m sure you don’t want that.
>>
>> Also here, may I suggest to use this commit title instead?
>> “xen/arm: smmuv3: Fix violations of MISRA C:2012 Rule 3.1”
>
> Just to mention it: Personally I'm averse to such double subject prefixes.
> Why would (here) "xen/smmuv3: " not be sufficient (and entirely unambiguous)?
With the changes suggested above.
Acked-by: Rahul Singh <rahul.singh@xxxxxxx>
Regards,
Rahul
|
