[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Wed, 5 Jul 2023 06:26:12 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OvBBDYnk7AdcK+fQoBH03oejcpKFeolnTm34igi6Iyw=; b=HQGWcGnar4O/KowZASvO05Le2he2sfoAnlt3jJJplsS+cZ6RmbySuPiNc+jAz/ximHJGm2HqYzQuYHmbiQ6zHQnaOL5sAXa5daomfI5KygNP5V6DeRMPYWKa988+ynGoUB3DNb7pqxbOuwSKYc80szNOoY82sOizWNURwE8TVaFhkUYDqfu/D2wlsDZNn3jVe9O2ffg97odKWYPXTqYceDZy3UBNtwjbHJTwLKrq3pEtJ0hhxCrgThWO6PYd/l5cVS8Bos9WmjQeARhluEeEx6lksvcWHfGhsD9lZjdcfXeOxT8Cm0KEq1X3CywVngIKzLO/TjAgDi1CRv57+/h3Ig==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cal+RpHZUlbkzT3kovTFueXm/CgSIOotho+Qfoyku15KwiiHZ5mvXXQyGOwoxQaOb21wIKNRRFKbsQm7uYu+jiPWx6+PgTIvQ4SZzlQvkkM19Et9LFj1wWwDQNp2g0MxVz1TQWHuGSce/Cl/BdnkB4L3I34oTm5PEvi1CQavr4HW2BLi1OD9lhGhkL4Le+DzxK9OrOFushWsfkOjcncMw5dGmQ+zY/Ftz7eKqe5lZG2M0ej5sjG4KS2/RJS04JVGSsXU3yYqjHSs1pIgpM2wbC0/5riARxG9ifhf/dwWAVF2dZdTPJfTRW6Y30IRjmk+9czoa3Tq6jnd7bfmCJokrQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Wed, 05 Jul 2023 06:26:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZmhGAbKd3CRm5gUS5RUtvHum0Za+pg22AgACfM4CAALxdgA==
  • Thread-topic: [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm


> On 4 Jul 2023, at 20:11, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi,
> 
> Replying here because there is no cover letter (in the future please add one 
> if you have more than two patches bundled together).

Sure I will

> 
> On 04/07/2023 10:42, Anthony PERARD wrote:
>> On Thu, Jun 08, 2023 at 02:59:12PM +0100, Luca Fancellu wrote:
>>> Commit 56a7aaa16bfe introduced some SVE related code that is protected by
>>> '#if defined(__aarch64__)', the issue is that this doesn't take into
>>> consideration when the toolstack is compiled for an arm32 Dom0 running on
>>> an arm64 platform, it should be able to create SVE enabled guests but with
>>> the current code it's not.
>>> 
>>> So fix the issue by compiling the code when the toolstack is compiled for
>>> both arm32 and arm64.
>>> 
>>> Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for 
>>> Arm")
>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> I have now committed the series.

Thank you

> 
> Cheers,
> 
> -- 
> Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.