Re: [PATCH v3 11/52] xen/arm: mmu: fold FIXMAP into MMU system

[Julien Grall <julien@xxxxxxx>]

Hi Penny,

On 05/07/2023 09:19, Penny Zheng wrote:
> On 2023/7/5 06:12, Julien Grall wrote:
> > On 26/06/2023 04:34, Penny Zheng wrote:
> > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > index fb77392b82..22b28b8ba2 100644
> > > --- a/xen/arch/arm/Kconfig
> > > +++ b/xen/arch/arm/Kconfig
> > > @@ -15,7 +15,6 @@ config ARM
> > >       select HAS_DEVICE_TREE
> > >       select HAS_PASSTHROUGH
> > >       select HAS_PDX
> > > -    select HAS_PMAP
> > >       select IOMMU_FORCE_PT_SHARE
> > >   config ARCH_DEFCONFIG
> > > @@ -63,11 +62,17 @@ source "arch/Kconfig"
> > >   config HAS_MMU
> > >       bool "Memory Management Unit support in a VMSA system"
> > >       default y
> > > +    select HAS_PMAP
> > >       help
> > >         In a VMSA system, a Memory Management Unit (MMU) provides 
> > > fine-grained control of
> > >         a memory system through a set of virtual to physical address 
> > > mappings and associated memory
> > >         properties held in memory-mapped tables known as translation 
> > > tables.
> > > +config HAS_FIXMAP
> > > +    bool "Provide special-purpose 4K mapping slots in a VMSA"
> >
> > Regardless what I wrote above, I don't think a developer should be 
> > able to disable HAS_FIXMAP when the HAS_MMU is used. So the 3 lines 
> > should be replaced with:
> > def_bool HAS_MMU
> Understood, will fix
Do you still need HAS_FIXMAP if this patch is dropped?

Cheers,

--
Julien Grall