[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/52] xen/arm: mmu: fold FIXMAP into MMU system
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Penny Zheng <penny.zheng@xxxxxxx>
- Date: Thu, 6 Jul 2023 16:00:06 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=id3mbd/WET/yOTr9X2S9gwoCRet20H+18f9ajyGqou0=; b=UCYLLvY6y5iDVeJbJLVTAqJsjkAFJJ9IAvCBix1l0GrjNSsirBynpJhgtt3smQD7N5I+SMh0tgaliwOH1Ya0KFfCUVRuKq42sARrd7rpmHjlO8v5T8izlytGlGlNIMiXYtj9ziPFsEZuW24vMtM//7Sf5N4GyMPjuh03MRiLxwVoWk42Q/ttCeWzdN89MQhAUYNRJJBUYsMsSynuzHVuEz/Xw4EBWj/KkE6JO/8BQD1SSDCu6AGkA/Zfgqqv75k0Qhn4z1f+lg+ogOVlP4OSC7r6NenbSVXsDeHAgO6oj3KMFfK4MHLhOY/KAV7sUOhbSJeih1JSTiL7U+HZBvHyhg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nicvspyILb/jPnu9/Wm9Ks72O2pA/PZl+DaoAQ+Jpti5RwkjrzIPItof+QMSJa579il+bOtXmONhr3DaS0ufzc0SmA3JlGxurPhEION2g/S0Laoy6r0qoRI/GrRxwPBbgYgb1+lK9Urx2lkKjF3lGgpINBmR1ljIxWQSv+XCVSiZSKihY8rPp//vsAvuO1WSiG8ttTzrnW/Qoqel+qTpuvIwTt3BHX/tt9jU02fE5STkyvZhi1qNHXaVSGI4qIqwjzMAiKpcaYaBpAiO0tHx2xEKzv6+kOdjyZPHh1XBmQzYbQiEdLmUWoohw9yj291NVKgx0xfXHx1zZ/m55FVj/w==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Chen <wei.chen@xxxxxxx>
- Delivery-date: Thu, 06 Jul 2023 08:00:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
Hi Julien
On 2023/7/5 18:31, Julien Grall wrote:
Hi Penny,
On 05/07/2023 09:19, Penny Zheng wrote:
On 2023/7/5 06:12, Julien Grall wrote:
On 26/06/2023 04:34, Penny Zheng wrote:
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index fb77392b82..22b28b8ba2 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -15,7 +15,6 @@ config ARM
select HAS_DEVICE_TREE
select HAS_PASSTHROUGH
select HAS_PDX
- select HAS_PMAP
select IOMMU_FORCE_PT_SHARE
config ARCH_DEFCONFIG
@@ -63,11 +62,17 @@ source "arch/Kconfig"
config HAS_MMU
bool "Memory Management Unit support in a VMSA system"
default y
+ select HAS_PMAP
help
In a VMSA system, a Memory Management Unit (MMU) provides
fine-grained control of
a memory system through a set of virtual to physical address
mappings and associated memory
properties held in memory-mapped tables known as translation
tables.
+config HAS_FIXMAP
+ bool "Provide special-purpose 4K mapping slots in a VMSA"
Regardless what I wrote above, I don't think a developer should be
able to disable HAS_FIXMAP when the HAS_MMU is used. So the 3 lines
should be replaced with:
def_bool HAS_MMU
Understood, will fix
Do you still need HAS_FIXMAP if this patch is dropped?
Right now, this patch only contains:
1) wrap PMAP into MMU
2) change static inline virt_to_fix() to declaration in fixmap.h and
definition in mmu/mm.c.
HAS_FIXMAP is not needed anymore.
Cheers,
|
