[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/4] x86/microcode: Ignore microcode loading interface for revision = -1
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 5 Jul 2023 15:13:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZheg9kcAvUSpKIAiMkLuHXH3CvT5QsCXu7xch1Jf60=; b=MUwIhoGpNoQIYtR15Lte2Die1GraY6zLSVDqvhctDEd0HZWauP+fz7aqyNOUPYmVGK3Ct0T1yfJMn+AX+06ujlAK27xnhqhUKh+D2qVkO8HiP1wLIbzAybfIg0DUQg6JftJzzLNiXDHsHgRJFdQnHywIF4OABi1o2NHiEalWiIn7UrkrQgvPS3jurI/4V/sNwqy+WUmVXsfhnYpVHTD9Cg5JupF4sJb0RZRMyuGq1fLZm6Zm2aO4NvnZXjDyGM+q/Fd2sPIQ7C+hM/2ovNvykt5E/2zh1Py890eS87xO79aICsLKBBE0KmfoP8WaligyzSGePY6fGffzXDnN7N/+Qw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HRunkEK7i/UhzP5n2OI8DxC71Fck9neVE+weqCxHj+nYd1dj0yiNO5dbY/QqqasIbAeZmN3taXOVAOz/zibrKgrbKAiiDLv4jg7VpB4TDXZ3FnZpLwc5fI02rhKGEx1pSxhxlEWt4AkS0sM11/Hi6kC1zkveI7Zbw3Tehhc3FoLcO9uwuISgWhqorEE7jL36zOJrpDOqt6RKwRwjsXo5m5ZxJ0TfWvBISetXpVMYbdStYNYrqrV0cd80V3UvZYYo1uhLI62sH7GEJxpRJJPawKuaDfQ05zMZIStjasu5s7obq1M/fel1rGbKfyJkrxZghcwOVSv+SV3UK4G7/GQpnA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 05 Jul 2023 14:14:39 +0000
- Ironport-data: A9a23:8xVbRKnxlyy0R4K/WdVt7FXo5gxBJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJD26COayNamegeowkbYuy800P657Wx9NlSgpqpHgyEyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5AKGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eU4cTYkbgiEvt+dxq2lUvQ3meEELOC+aevzulk4pd3YJdAPZMmbBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieCzWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTebpq6c32gL7Kmo7OF4ubVK6rNKCrG2HRu0AC UgoxDYRlP1nnKCsZpynN/Gim1aNuhMeUtxcCep89giJzqfW5C6SAm8ZQnhKb9lOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgcqZyUJUA8E6NnLu5wog1TESdMLOLGxps34H3f32 T/ikcQlr7AajMpO0rrh+1nC2mqovsKQFlBz4RjLVGW46A8/fJSie4Gj9Vnc67BHMZqdSV6C+ nMDnqBy8dwzMH1ErwTVKM1lIV1jz6/t3OH06bK3I6Qcyg==
- Ironport-hdrordr: A9a23:OifEKarXwMpylJ2vuMg9PTUaV5pIeYIsimQD101hICG9E/b5qy nKpp8mPHDP5Qr5NEtLpTniAsi9qA3nmqKdiLN5VYtKNzOLhILHFu9f0bc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/06/2023 4:26 pm, Alejandro Vallejo wrote:
> diff --git a/xen/arch/x86/cpu/microcode/core.c
> b/xen/arch/x86/cpu/microcode/core.c
> index bec8b55db2..b620e3bfa6 100644
> --- a/xen/arch/x86/cpu/microcode/core.c
> +++ b/xen/arch/x86/cpu/microcode/core.c
> @@ -867,10 +867,22 @@ int __init early_microcode_init(unsigned long
> *module_map,
> return -ENODEV;
> }
>
> - microcode_grab_module(module_map, mbi);
> -
> ucode_ops.collect_cpu_info();
>
> + /*
> + * Some hypervisors deliberately report a microcode revision of -1 to
> + * mean that they will not accept microcode updates. We take the hint
> + * and ignore the microcode interface in that case.
> + */
> + if ( this_cpu(cpu_sig).rev == ~0 )
> + {
> + printk(XENLOG_WARNING "Microcode loading disabled\n");
XENLOG_INFO "Found microcode revision ~0; Disabling loading because of
virt\n"
It's normal (and not a warning) when running under other hypervisors,
and just "loading disabled" is too little information.
Happy to fix on commit. Everything else looks ok.
~Andrew
|
