[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/4] x86/microcode: Ignore microcode loading interface for revision = -1
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 5 Jul 2023 16:24:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHTD7xr08KeyYTp781kIA9UvGB/ybvIaCBq3czqtgSU=; b=WnEE4d/QYkhFTGsajT3Y8HoD1T1iiZkQ/HpkH2bUyDp8Jk9LHwZ0QhqJZ+AEZbl9gt/YITp2qKbbMvnYyZ6FI6tzI6rk27kDfaDtzr8J3SrdrRpJ8BlNibXsLC+g+NGq/gM7Q0KBvItpWhI6nIbP/62gR1PoMUmwHyaB6TyhE4XutZTNGOBJxTCGcXOXS7RFCF2sp5L9OoeQ5fn+XLH1weWW3QY3S3/Bho+/nMKNt26HTnZ1oG/GyZQtAyOgEz5h1ctXa5ircL+Uk8WltvUEy4n6i0AxFbjE1TUjUZETeDzw8bndZOO7UJNI1lEZ8wVSvIiTFfwfIRM3MCinbKbe1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J99eCFFdYfNAfb9lgMeJOHlqkJ9gjtodwn3QNiLcIME6/v8mgkYyox82H47If5Q9xrAaDcjRv9BMDffvlsqvotzt+ERwT/iMpw6BBiX7muOaS8V+yiI7XSqTuSACbr/iqaSU25eNV8MrXlIBWkAw6LAcorX+Ykz29TNztcDv3DYyzQPOtIHO+9aaeqkyuHwS1kBrIXTaN60PNIXbCJ1JRZOn4fZrFbpqPGNvX/XzrhM/HFr8pSlIjstguEwYtpVY2QnfR0yS5isHcVL8+3iGt0Jkf/xXgFWlKERHr1F/3AflIdEPHTi4rxlz+I1STD88nyZGfL/1+BMIuJyZiePU/w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- Delivery-date: Wed, 05 Jul 2023 14:25:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.07.2023 16:13, Andrew Cooper wrote:
> On 29/06/2023 4:26 pm, Alejandro Vallejo wrote:
>> diff --git a/xen/arch/x86/cpu/microcode/core.c
>> b/xen/arch/x86/cpu/microcode/core.c
>> index bec8b55db2..b620e3bfa6 100644
>> --- a/xen/arch/x86/cpu/microcode/core.c
>> +++ b/xen/arch/x86/cpu/microcode/core.c
>> @@ -867,10 +867,22 @@ int __init early_microcode_init(unsigned long
>> *module_map,
>> return -ENODEV;
>> }
>>
>> - microcode_grab_module(module_map, mbi);
>> -
>> ucode_ops.collect_cpu_info();
>>
>> + /*
>> + * Some hypervisors deliberately report a microcode revision of -1 to
>> + * mean that they will not accept microcode updates. We take the hint
>> + * and ignore the microcode interface in that case.
>> + */
>> + if ( this_cpu(cpu_sig).rev == ~0 )
>> + {
>> + printk(XENLOG_WARNING "Microcode loading disabled\n");
>
> XENLOG_INFO "Found microcode revision ~0; Disabling loading because of
> virt\n"
>
> It's normal (and not a warning) when running under other hypervisors,
Except that INFO won't be visible by default in release configurations.
Jan
> and just "loading disabled" is too little information.
>
> Happy to fix on commit. Everything else looks ok.
>
> ~Andrew
|
