[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/4] x86/microcode: Ignore microcode loading interface for revision = -1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 5 Jul 2023 15:28:07 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C6o5fL6QH4qo/QG/Pszbms0PnXNz92j6WRyXhSYHkkw=; b=f2E1wLIv12gA4cxlUpLFNpynvUZeaOc0OOuKPuWC/948Ry2AvseoAS4snTmDygKgfn1kWMOfkMRvXyJIhJunwZN7E9vp/9dzch8ui3UICq3EFwwA8FiOByM1qmKTrpWLBuEGgiZI4EdGnPLcyl7zIkPW6SjHylRQz0LxXnL1CPpGzqBkjb8Mf98OSHUt00V4aAZcSDvUCIJCb4WTm1O7cM0c68achfTa23/HuUIhbx/2GxBc49+PE5XHTKwOzAidYtRyR8aj9ukEGFJv63XEs4TrKj4URbCgHGsNRBjYEOz6R7hDTtSFEG8yUNJaR40z1sjO6mOUX/VTiaT9Ka3TsA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OUBlQkeDqgJvFJ6IXImmBLeQN4W+hEbZ5QlGDkxLVfbAw+1susQE/jF8OyEuf7qRjaP8etpbjXkEodKd0c02Rd917lJFdsBidHy1Uyo6Qly4MFt3SAdmchoc5p6royuGUHTTAgQdMH8j+A6mcctv5q5PtX7A7dqfj3MGhL9GnnQKlZ+InR86pFfTToCmghRV6YUKHt0Wzx2VYigwoPCoCmPtuiFU+lEVApzCH8uyi+6ZGxyD1HsrXWGch03AtdrM+WF8Vqs4IqN+qFdb78DZpYF1Q2OqeYUyonxpZtemRLD8h92OnkYMi/B6bhBU1XNmtq3lv6PCFVophs5v+sezBg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- Delivery-date: Wed, 05 Jul 2023 14:28:30 +0000
- Ironport-data: A9a23:SpqrW6Ms+pVSp37vrR1llsFynXyQoLVcMsEvi/4bfWQNrUoi12MPy 2ZJCG3Xb6qOZGr1fNt0a4mz8UlSsJOGnYRmTQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/vrRC9H5qyo42tH5gFmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tcsBWJjx 9wxFD4yVQ+/uOeZxbu4R9A506zPLOGzVG8ekldJ6GiBSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujCDpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eWxH6lBd5OTO3QGvhCpmep6nUWSx8sTEqKhdOCikuDZdFaN BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml1a788wufQG8eQVZpeNEg8cM7WzEu/ luIhM/yQyxitqWPTnCQ/avSqim9UQAcKWIAbCkIVwxD/dDnpIwxiTrEStF+HOi+ididJN3r6 zWDrSx7i7BNi8cOjv2/5Qqe22LqoYXVRAko4AmRRnii8g5yeI+iYcqv9ETf6vFDao2eSzFto UQ5piRX18hWZbnlqcBHaL9l8G2BjxpdDADhvA==
- Ironport-hdrordr: A9a23:Yn+wM6D0TAyUo8nlHehnsceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPHjP+UYssRAb6KG90cy7KxLhHPFOkPEs1NuZLXLbUQiTXf9fBOnZskHd8kTFn4Y3uM cQENkbebqAaykCsSvj2njcLz9K+qj7zEnHv5al854gd3AUV0hV1XYLNu/XKDw6eOEAbqBJY6 a0145inX6NaH4XZsO0Cj0sWPXCncTCkNbcbRsPF3ccmUGzZZ/B0s+NL/DNtC1uMQ9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDLNbksLlWFhzcziKTIKhxUbyLuz445Mu17kwxrd XKqxA8e+xu9nLqeH2vqxeF4Xii7N8X0Q6m9bakuwqjnSW5fkN1NyN5v/MXTvIN0TthgDl+uJ g7ll5x+aAnSS8opx6Nk+QgZysa5HZcnkBS5NL7r0YvGrf2O4Uh57D3unklXKsoLWbC84YgH/ BpDMbAoNhrUX7yVQGfgkBfhOW2WHI9BxGHRVVHnPe0/Xx5oFBVpnFogvD2uB87hcoAol1/lr 35Dpg=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/07/2023 3:24 pm, Jan Beulich wrote:
> On 05.07.2023 16:13, Andrew Cooper wrote:
>> On 29/06/2023 4:26 pm, Alejandro Vallejo wrote:
>>> diff --git a/xen/arch/x86/cpu/microcode/core.c
>>> b/xen/arch/x86/cpu/microcode/core.c
>>> index bec8b55db2..b620e3bfa6 100644
>>> --- a/xen/arch/x86/cpu/microcode/core.c
>>> +++ b/xen/arch/x86/cpu/microcode/core.c
>>> @@ -867,10 +867,22 @@ int __init early_microcode_init(unsigned long
>>> *module_map,
>>> return -ENODEV;
>>> }
>>>
>>> - microcode_grab_module(module_map, mbi);
>>> -
>>> ucode_ops.collect_cpu_info();
>>>
>>> + /*
>>> + * Some hypervisors deliberately report a microcode revision of -1 to
>>> + * mean that they will not accept microcode updates. We take the hint
>>> + * and ignore the microcode interface in that case.
>>> + */
>>> + if ( this_cpu(cpu_sig).rev == ~0 )
>>> + {
>>> + printk(XENLOG_WARNING "Microcode loading disabled\n");
>> XENLOG_INFO "Found microcode revision ~0; Disabling loading because of
>> virt\n"
>>
>> It's normal (and not a warning) when running under other hypervisors,
> Except that INFO won't be visible by default in release configurations.
Well that's not a bug with microcode then, is it...
I can't believe I'm having to say no to emitting messages at the wrong
log level to work around a bug with selecting the default log level in
the first place.
~Andrew
|
