[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/3] cmdline: parse multiple instances of the vga option


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 6 Jul 2023 12:45:41 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bp026+l+SXvaxUzxwK97199lQP8K0Mm67wbPdTQF5rg=; b=IbBEuePPWEFQ3SvBQrHapW5Ug3ub21ugFQe+mBeFc2oc69VRSoEdgWJ9iH0epOdMiN3TSX17c0i/PuSdx18kdl7XasgkYe86IAf5sUIxxGWxRYuaF7aq6KzEOh3jUUvxf1kcEZkN8cVCK0VFEvJa6S4fvd/8zvVFpdrbaY3lFC0KhoIHGwjnXJkVinnhCOtVvQYytCjXcCyoni2fVmRiRP2U+g7wyLUgzS4tTCnr2IXJG2TjVfzAEgCI77EPQPv505LJNsRhJzm5eBVPxlw4T+MQaQ2aovrh3MwHmFIqyYv6TjpFtpxu3JUSXBejVU5Xq6WJx+hj9F34Fdyqnb4vjQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CUQ6jlEK+XqSfQNpIInl4N4uwLR6eaqP2ywb6LhtW2VGVlcaNSFqIatIEWH6ywau7R0fOF5ws1Oh5dsH6hq4Zr11rJ4qYtZnOeha5Bv4b3vG+XzFytK8J86d4dGBowRLUPRfreFCK0u8YrpSZLk8eAQ2YZ6/GBoesvC32y71MwnadLLoeUX3xw0f8VNdCEe5w7RmvayWipQpIEKdxTDvIsCTFb+EyjhfB9tyxYJ2EbFQkAiC5TobTCdn7ELXNmTxfKtcUFzzWCGPfzQFmEEhwiR8/BG1pU9hqU49GzLmaE/aZrNckmd2UDTiYDhcZxefkhwQzhfvip9cb3V3uiLYGQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 06 Jul 2023 10:45:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05.07.2023 13:47, Roger Pau Monne wrote:
> Parse all instances of the vga= option on the command line, in order
> to always enforce the last selection on the command line.
> 
> Note that it's not safe to parse just the last occurrence of the vga=
> option, as then a command line with `vga=current vga=keep` would
> result in current being ignored.
> 
> Adjust the command line documentation to describe the new behavior.

This was likely meant to be dropped along with ...

> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Changes since v3:
>  - Remove xen-command-line doc addition.

... this? Beyond that (easy to adjust while committing)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.