[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/3] cmdline: parse multiple instances of the vga option


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 7 Jul 2023 12:13:59 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ENTzTDoOFWECKo+jyH04E8Zqb0CNSQo4DQc0MGHkO1Q=; b=EqNxpkXsHbYOpT+UzKmndsSH2c75bG/FCTZceLMYW/u5olXQ2xXFQ0lmVFPCraNQmmKPTX7vb8hDMhTF0NCheiCBpydAFs+OOjnvy6CrgKlUIkrAU+CTkCu7hKyJe2iMXzQFQByy7iPHSzbTpaCJpB+Yd75ZDInyCjSbsXDp52rYwDyUpyXcN2JZW1sNrGIJmam463XkEVJV15zTl1aR4UyA40XjiMWZos6KUP8MRd/hUAbM+mCT9P6bb+VAoNNOMScAt7tZqq7q0YPTtRG3hMkyn7QyhX+brfHElU+fsWx0o5ReQINYN0M4hs5oewl4MOJ4n1gCdLZbgRm/EjyqNA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RbjIFjLBJvYDdi7l7xm5H6Ji6NmLlKr7Jisn0IwdUQ952IgXWOcNhfpBkPq6ICCCCKjgrDrHcWUByLFJi3foyJxzNHxgVUfibH/DM9p28rHaHqs+OaBTuZViYRn/YQrVnTYDzAdvzDN/qpKE9HFm/B0Ohh66WhikgsSAWpWcvfz20slIHw8ml87DMl2+mpR3AUlrsog0VmkbMCJOEwi8eL7efUzOekWiv1jZgWhw+1O8TEptBzItLbqXSV9MP0K95CygvolpCrBp6i+09sYdJxsue2Bx5umKYd8Kxe1NrAQBQ/5L4sn6mYOMbvIBxuxP9KY7tqVE21o8bq4U/slidg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 07 Jul 2023 10:14:17 +0000
  • Ironport-data: A9a23:QKhezaK9KZfBtOtVFE+R95QlxSXFcZb7ZxGr2PjKsXjdYENS1DMAy GVMDWqHa6mPN2T0fNlxaYW2/BkFvZWGyIM1G1dlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA4QRhPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5HB013/ qAxCQoTc0mJp76o6ruEeudF05FLwMnDZOvzu1lG5BSAVbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGLlWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv12raQzH2gAer+EpW+/PlugECdm1AtARhPDF6Rv9ajqGOhDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Ul7Cmdx6yS5ByWbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8kN+pES0cLGtHaSpaSwIAuoHnuNtq1kuJSct/GqmoiNGzASv33 z2BsCk5gfMUkNIP0KK4u1vAhlpAu6T0c+L83S2PNkrN0++zTNfNi1CAgbQD0ct9EQ==
  • Ironport-hdrordr: A9a23:pt+XCqp998smUQPdYy10rjoaV5pIeYIsimQD101hICG9E/b5qy nKpp8mPHDP5Qr5NEtLpTniAsi9qA3nmqKdiLN5VYtKNzOLhILHFu9f0bc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Jul 06, 2023 at 12:45:41PM +0200, Jan Beulich wrote:
> On 05.07.2023 13:47, Roger Pau Monne wrote:
> > Parse all instances of the vga= option on the command line, in order
> > to always enforce the last selection on the command line.
> > 
> > Note that it's not safe to parse just the last occurrence of the vga=
> > option, as then a command line with `vga=current vga=keep` would
> > result in current being ignored.
> > 
> > Adjust the command line documentation to describe the new behavior.
> 
> This was likely meant to be dropped along with ...
> 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Changes since v3:
> >  - Remove xen-command-line doc addition.
> 
> ... this? Beyond that (easy to adjust while committing)
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Oh, indeed, I've added the changelog and didn't adjust the commit
message.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.