[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cmdline: only set ask mode if vga= is present
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 11 Jul 2023 12:27:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t/TVrBzVsIwR96YK41lnB70vLndn90VY8LjQ0zG8wNk=; b=dkF3AsdpNIkIB3XxYlLIOcVpQ0O1BFiVD0o33K9zB8JuVANcNw9B8ho+vakpiAHogCnJhjGcbLq25Tp2EblVPPKUjLf4RL+5AVOXNQrgKkOcw4zn6zBt4I0CE/4v8eMxutA/sFdNaY6PC5sN5AbAOfT2Cr9VLuma5HTFddPfQisuP94YkwUIGrDbzIbETbDZ0tbxh43EUuzXDBhC6D6fcYYbmuLZ0J9R29H/1npjjpscR66RyclFbiurdEZ5lHvwIB+eJmJU+07QesQo1g9M8B3xqy92HgKI/exoh6mEUon0kzY6nLuJCnRaphBNARnUeGLVcMyFGUvglqgDSfmH2Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWOMNNSAjNOfWOx4LrUhwG6JBohPR9JLo3aZMAumxcWx09emzPT+HEnG4EfPdhV4KV4pZP5jRz9SlYFCaEfnC6C2IVLQQIXK6fLqeZSzb3xfkqQF1AIu7cSDG2ME6RLA0A+56AcdUuEVTbM76UOH+2EbFFUwuvTHv5jaCPCoFXq1r4h1r8qgjfHEY0QVHjj+/CCULvOGBRE/vm1OyVKHtMP9vs+l4ptz16a7fPuUd+7YXQUbXpYKjLZxSNvv9/PdmYS2IxXzS/FI+tv5fdbI17rWxzAA0sjtLE+FAYuMnhki7jEQFRKM4SCV4JqAHEKzSFgwoHirhzhFp+8PPQASvg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 11 Jul 2023 10:27:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.07.2023 11:14, Roger Pau Monné wrote:
> On Mon, Jul 10, 2023 at 06:27:06PM +0200, Jan Beulich wrote:
>> On 10.07.2023 16:12, Roger Pau Monne wrote:
>>> Commit 9473d9a24182 set the ASK mode without checking if there was a
>>> `vga` option provided in the command line. This breaks existing
>>> behavior, so exit early without changes if `vga` is not present in the
>>> command line.
>>>
>>> Fixes: 9473d9a24182 ('cmdline: parse multiple instances of the vga option')
>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> Should have spotted this during review; effectively you're (almost) undoing
>> part of the earlier change, just that ...
>>
>>> --- a/xen/arch/x86/boot/cmdline.c
>>> +++ b/xen/arch/x86/boot/cmdline.c
>>> @@ -279,9 +279,13 @@ static void vga_parse(const char *cmdline,
>>> early_boot_opts_t *ebo)
>>> {
>>> const char *c = cmdline;
>>>
>>> + c = find_opt(c, "vga=", true);
>>
>> ... you use c instead of cmdline here (and I'm heavily tempted to actually
>> make this the initializer of c).
>
> I see, yes, please do.
Well, no, I didn't (without your consent), and I wanted to get the patch
in yesterday before leaving.
Jan
|
